xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Olaf Hering <olaf@aepfle.de>,
	George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH for-4.7] Revert "libxl: No emulated disk driver for xvdX disk"
Date: Wed, 8 Jun 2016 17:00:13 +0100	[thread overview]
Message-ID: <5758410D.8090704@citrix.com> (raw)
In-Reply-To: <20160608155239.GD28116@citrix.com>

On 08/06/16 16:52, Wei Liu wrote:
> On Wed, Jun 08, 2016 at 04:32:13PM +0100, Ian Jackson wrote:
>> Wei Liu writes ("[PATCH for-4.7] Revert "libxl: No emulated disk driver for xvdX disk""):
>>> This reverts c0c099d157cc5bc942afef766cf141628a6380a1.
>>>
>>> That commit causes regression on the semantics of our diskspec.
>>> See [0] for more information.
>>>
>>> [0] http://lists.xen.org/archives/html/xen-devel/2016-05/msg02876.html
>>>
>>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>>> ---
>>> Please review carefully about this patch. There are one commit that is
>>> of interest: ef6cb76026628e26e3d1ae53c50ccde1c3c78b1b
>>>
>>> I believe the reverting the snippet in question won't cause security
>>> issue as described in XSA-142, because the code to create IDE disk still
>>> checks if the disk is read-only.
>>
>> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>>
>> I think this is the right answer for 4.7.  In 4.8 we should do
>> something like one of the proposals being discussed in this thread.
>>
> 
> Thanks.  And Anthony said on IRC this patch looked good to him.
> 
> I've queued this for committing to both unstable and 4.7.

CC'ing Olaf and Konrad for their information. :-)

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-08 16:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 15:31 [PATCH for-4.7] Revert "libxl: No emulated disk driver for xvdX disk" Wei Liu
2016-06-08 15:32 ` Ian Jackson
2016-06-08 15:52   ` Wei Liu
2016-06-08 16:00     ` George Dunlap [this message]
2016-06-08 16:17       ` Olaf Hering
2016-06-08 17:55         ` Konrad Rzeszutek Wilk
2016-06-09 13:23           ` Olaf Hering
2016-06-13  8:41             ` George Dunlap
2016-06-13 10:21               ` Olaf Hering
2016-06-13 10:23                 ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5758410D.8090704@citrix.com \
    --to=george.dunlap@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=olaf@aepfle.de \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).