From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@arm.com>, Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen/init: Annotate all command line parameter infrastructure as const
Date: Thu, 9 Jun 2016 15:28:39 +0100 [thread overview]
Message-ID: <57597D17.4060609@citrix.com> (raw)
In-Reply-To: <57597AFE.7020801@arm.com>
On 09/06/16 15:19, Julien Grall wrote:
> Hi Andrew,
>
> On 09/06/16 14:45, Andrew Cooper wrote:
>> On 09/06/16 13:39, Jan Beulich wrote:
>>>>>> On 09.06.16 at 11:58, <andrew.cooper3@citrix.com> wrote:
>>>> --- a/xen/arch/arm/xen.lds.S
>>>> +++ b/xen/arch/arm/xen.lds.S
>>>> @@ -135,6 +135,12 @@ SECTIONS
>>>> *(.init.rodata)
>>>> *(.init.rodata.rel)
>>>> *(.init.rodata.str*)
>>>> +
>>>> + . = ALIGN(POINTER_ALIGN);
>>>> + __setup_start = .;
>>>> + *(.init.setup)
>>>> + __setup_end = .;
>>>> +
>>>> *(.init.data)
>>>> *(.init.data.rel)
>>>> *(.init.data.rel.*)
>>>> @@ -145,11 +151,6 @@ SECTIONS
>>>> __ctors_end = .;
>>>> } :text
>>>> . = ALIGN(32);
>>>> - .init.setup : {
>>>> - __setup_start = .;
>>>> - *(.init.setup)
>>>> - __setup_end = .;
>>>> - } :text
>>>> .init.proc.info : {
>>> Surely that ALIGN() then has no reason to retain the 32 (similar
>>> for x86)?
>>
>> I don't know where this ALIGN() came from, but I am hesitant to remove
>> it until I am sure it is safe to do so.
>>
>> For both x86 and arm, .initcall will take a little more work to
>> disentangle, although I do intend to make it happen.
>>
>> On arm, .init.proc.info is an array of 32byte elements. Looking at its
>> contents, it should be constant, and probably wants 4 byte alignment as
>> opposed to 32.
>
> proc_info_list contains some pointers, so we want 4-byte for ARM32 and
> 8-byte for ARM64. I would use POINTER_ALIGN here.
I will add a patch to my series making this change.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-09 14:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 9:58 [PATCH] xen/init: Annotate all command line parameter infrastructure as const Andrew Cooper
2016-06-09 9:58 ` [PATCH] xen/xsm: Annotate xsm_initcall() data " Andrew Cooper
2016-06-09 12:40 ` Jan Beulich
2016-06-09 14:26 ` Daniel De Graaf
2016-06-09 14:28 ` Andrew Cooper
2016-06-09 9:58 ` [PATCH] x86/boot: copy/clear sections more efficiently Andrew Cooper
2016-06-09 12:42 ` Jan Beulich
2016-06-09 10:03 ` [PATCH] xen/init: Annotate all command line parameter infrastructure as const Andrew Cooper
2016-06-09 12:39 ` Jan Beulich
2016-06-09 13:45 ` Andrew Cooper
2016-06-09 14:19 ` Julien Grall
2016-06-09 14:20 ` Julien Grall
2016-06-09 14:28 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57597D17.4060609@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).