xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen/xsm: Annotate xsm_initcall() data as const
Date: Thu, 09 Jun 2016 06:40:06 -0600	[thread overview]
Message-ID: <57597FC602000078000F376C@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1465466335-19761-2-git-send-email-andrew.cooper3@citrix.com>

>>> On 09.06.16 at 11:58, <andrew.cooper3@citrix.com> wrote:
> --- a/xen/include/xsm/xsm.h
> +++ b/xen/include/xsm/xsm.h
> @@ -51,7 +51,7 @@ typedef void (*xsm_initcall_t)(void);
>  extern xsm_initcall_t __xsm_initcall_start[], __xsm_initcall_end[];
>  
>  #define xsm_initcall(fn) \
> -    static xsm_initcall_t __initcall_##fn \
> +    static const xsm_initcall_t __initcall_##fn \
>      __used_section(".xsm_initcall.init") = fn

Same here - please make the bounding symbol declarations then
const too.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-09 12:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09  9:58 [PATCH] xen/init: Annotate all command line parameter infrastructure as const Andrew Cooper
2016-06-09  9:58 ` [PATCH] xen/xsm: Annotate xsm_initcall() data " Andrew Cooper
2016-06-09 12:40   ` Jan Beulich [this message]
2016-06-09 14:26   ` Daniel De Graaf
2016-06-09 14:28     ` Andrew Cooper
2016-06-09  9:58 ` [PATCH] x86/boot: copy/clear sections more efficiently Andrew Cooper
2016-06-09 12:42   ` Jan Beulich
2016-06-09 10:03 ` [PATCH] xen/init: Annotate all command line parameter infrastructure as const Andrew Cooper
2016-06-09 12:39 ` Jan Beulich
2016-06-09 13:45   ` Andrew Cooper
2016-06-09 14:19     ` Julien Grall
2016-06-09 14:20       ` Julien Grall
2016-06-09 14:28       ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57597FC602000078000F376C@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).