Re: [PATCH 10/15] flask: remove xen_flask_userlist operation

["Jan Beulich" <JBeulich@suse.com>]

>>> On 10.06.16 at 15:08, <dgdegra@tycho.nsa.gov> wrote:
> On 06/10/2016 02:51 AM, Jan Beulich wrote:
>>>>> On 09.06.16 at 18:43, <dgdegra@tycho.nsa.gov> wrote:
>>> On 06/09/2016 12:07 PM, Jan Beulich wrote:
>>>>>>> On 09.06.16 at 16:47, <dgdegra@tycho.nsa.gov> wrote:
>>>>> --- a/xen/include/public/xsm/flask_op.h
>>>>> +++ b/xen/include/public/xsm/flask_op.h
>>>>> @@ -70,20 +70,6 @@ struct xen_flask_transition {
>>>>>      uint32_t newsid;
>>>>>  };
>>>>>
>>>>> -struct xen_flask_userlist {
>>>>> -    /* IN: starting SID for list */
>>>>> -    uint32_t start_sid;
>>>>> -    /* IN: size of user string and output buffer
>>>>> -     * OUT: number of SIDs returned */
>>>>> -    uint32_t size;
>>>>> -    union {
>>>>> -        /* IN: user to enumerate SIDs */
>>>>> -        XEN_GUEST_HANDLE(char) user;
>>>>> -        /* OUT: SID list */
>>>>> -        XEN_GUEST_HANDLE(uint32) sids;
>>>>> -    } u;
>>>>> -};
>>>>
>>>> No known users or not, we don't normally allow breaking code that
>>>> may be consuming any of our public headers. I.e. conventionally,
>>>> for interfaces not restricted to the tool stack we keep everything,
>>>> but guard it with a __XEN_INTERFACE_VERSION__ conditional.
>>>>
>>>> Whether making an exception here is okay I'm not certain; in any
>>>> event would you imo need to bump XEN_FLASK_INTERFACE_VERSION.
>>>
>>> OK, then I'll drop this patch.
>>
>> Well, no, please don't drop it, make it add aforementioned #if-s.
>> (And after thinking about it again, bumping the interface version
>> doesn't seem to make sense for a plain removal.)
> 
> Ah, I misunderstood your comment - I read the conditional as belonging
> to the code instead of the header, which makes a lot more sense.
> 
> Does the value of __XEN_LATEST_INTERFACE_VERSION__ need to be bumped to
> 0x00040800 after the branching process?

Whenever that's first needed. One of the patches I have in the
works does so, but if yours lands earlier it should do the update.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel