From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [Xen-devel] [PULL 3/4] xen: add pvUSB backend Date: Mon, 13 Jun 2016 09:55:01 +0200 Message-ID: <575E66D5.4070109@suse.com> References: <1464009123-5814-1-git-send-email-kraxel@redhat.com> <1464009123-5814-4-git-send-email-kraxel@redhat.com> <20160607083530.GA6238@gmail.com> <1465555123.2920.9.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1465555123.2920.9.camel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: "Qemu-devel" To: Gerd Hoffmann , Olaf Hering Cc: Anthony Perard , "open list:X86" , Stefano Stabellini , qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org On 10/06/16 12:38, Gerd Hoffmann wrote: > On Di, 2016-06-07 at 10:35 +0200, Olaf Hering wrote: >> On Mon, May 23, Gerd Hoffmann wrote: >> >>> +++ b/hw/usb/Makefile.objs >>> +common-obj-$(CONFIG_XEN_BACKEND) += xen-usb.o >>> +++ b/hw/usb/xen-usb.c >>> + usb_bus_new(&usbif->bus, sizeof(usbif->bus), &xen_usb_bus_ops, xen_sysdev); >> >> xen_sysdev is in an i386-only file, as a result qemu fails to link. > > Ping. Juergen? Xen folks? Can anyone have a look please? Sorry, just was 3 weeks offline due to moving across Germany (900 km). > I think the fix would be s/xen_sysdev/xendev/, but I can't test that > myself. I think the proper solution is to move the xen_sysdev definition and initialization from hw/xenpv/xen_machine_pv.c to hw/xen/xen_backend.c I'll send a patch. Juergen