xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>,
	glenn@rimuhosting.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0
Date: Tue, 14 Jun 2016 12:31:02 +0200	[thread overview]
Message-ID: <575FDCE6.3090902@suse.com> (raw)
In-Reply-To: <22367.55139.582581.11528@mariner.uk.xensource.com>

On 14/06/16 12:07, Ian Jackson wrote:
> Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0"):
>> On Tue, Jun 14, 2016 at 11:01:50AM +0200, Dario Faggioli wrote:
>>> On Tue, 2016-06-14 at 06:30 +0200, Juergen Gross wrote:
>>>> When trying to use xl cpupool-numa-split and dom0 is limited to less
>>>> vcpus than one numa node the operation will fail.
>>>> Correct this by allowing this configuration.
>>>> Reported-by: Glenn Enright <glenn@rimuhosting.com>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
>> Acked-by: Wei Liu <wei.liu2@citrix.com>
>> I think this is also a backport candidate?
> Possibly.
> I looked at the code for a minute or two, and perhaps I'm being dense
> this morning, but I wasn't able to see (from the code and the commit
> message and from the diff) precisely what misunderstanding the
> original author of the code had, and how this patch fixes it.

The problem arises if dom0 has less vcpus than a numa node. In this case
libxl_set_vcpuonline() will fail as the cpumap has more bits set than
the number of dom0's vcpus.

My patch will result in a call of libxl_set_vcpuonline() only in case
dom0 has more vcpus online than the number of cpus of node it is to be
restricted to.

> I don't want to backport (non-security) things unless they have a very
> low chance of regressions.  So perhaps someone could either explain it
> to me, or assert convincingly that they are sure it's right :-).


Xen-devel mailing list

  reply	other threads:[~2016-06-14 10:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14  4:30 Juergen Gross
2016-06-14  9:01 ` Dario Faggioli
2016-06-14  9:56   ` Wei Liu
2016-06-14  9:58     ` Wei Liu
2016-06-14 10:05       ` Juergen Gross
2016-06-17 10:44         ` Wei Liu
2016-06-14 10:07     ` Ian Jackson
2016-06-14 10:31       ` Juergen Gross [this message]
2016-06-14 14:28         ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575FDCE6.3090902@suse.com \
    --to=jgross@suse.com \
    --cc=dario.faggioli@citrix.com \
    --cc=glenn@rimuhosting.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --subject='Re: [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).