From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Bob Liu <bob.liu@oracle.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
roger.pau@citrix.com
Subject: Re: [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback
Date: Wed, 15 Jun 2016 09:39:00 +0100 [thread overview]
Message-ID: <57611424.2020802__31505.9215332896$1465980007$gmane$org@citrix.com> (raw)
In-Reply-To: <20160608144739.GD17027@char.us.oracle.com>
On 06/08/2016 03:47 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Jun 08, 2016 at 02:46:38PM +0800, Bob Liu wrote:
>>
>> On 06/07/2016 11:25 PM, Konrad Rzeszutek Wilk wrote:
>>> On Wed, Jun 01, 2016 at 01:49:23PM +0800, Bob Liu wrote:
>>>>
>>>> On 06/01/2016 04:33 AM, Konrad Rzeszutek Wilk wrote:
>>>>> On Tue, May 31, 2016 at 04:59:16PM +0800, Bob Liu wrote:
>>>>>> Sometimes blkfont may receive twice blkback_changed() notification after
>>>>>> migration, then talk_to_blkback() will be called twice too and confused
>>>>>> xen-blkback.
>>>>>
... snip
>>>> But sometimes blkfront receives
>>>> blkback_changed() event more than once!
>>>
>>> I think I know why. The udev scripts that get invoked when when
>>> we attach a disk are a bit custom. As such I think they just
>>> revalidate the size leading to this.
>>>
>>> And this 'poke-at-XenbusStateConnected' state multiple times
>>> is allowed. It is used to signal disk changes (or just to revalidate).
>>> Hence it does not matter why really - we need to deal with this.
>>>
>>> I modified your patch a bit and are testing it:
>>>
>>
>> Looks much better, thank you very much!
>
> Great! I also had it tested overnight and there was no hitch will send it
> out soon.
>
I'd like to request that this patch is backported to Linux 4.5 and both
of the patches in this series are backported to Linux 4.6. This is
affecting Debian Testing (using Linux 4.6). It fails to recover its disk
when resuming or migrating.
Thanks,
--
Ross Lagerwall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-15 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1464685157-30738-1-git-send-email-bob.liu@oracle.com>
2016-05-31 8:59 ` [PATCH 2/2] xen-blkfront: fix resume issues Bob Liu
2016-05-31 20:33 ` [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback Konrad Rzeszutek Wilk
[not found] ` <20160531203307.GC23808@char.us.oracle.com>
2016-06-01 5:49 ` Bob Liu
[not found] ` <574E7763.9060001@oracle.com>
2016-06-02 14:30 ` Konrad Rzeszutek Wilk
2016-06-07 15:25 ` Konrad Rzeszutek Wilk
[not found] ` <20160607152524.GA10281@localhost.localdomain>
2016-06-08 6:46 ` Bob Liu
[not found] ` <5757BF4E.9080307@oracle.com>
2016-06-08 14:47 ` Konrad Rzeszutek Wilk
[not found] ` <20160608144739.GD17027@char.us.oracle.com>
2016-06-15 8:39 ` Ross Lagerwall [this message]
[not found] ` <57611424.2020802@citrix.com>
2016-06-15 14:08 ` Konrad Rzeszutek Wilk
2016-05-31 8:59 Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='57611424.2020802__31505.9215332896$1465980007$gmane$org@citrix.com' \
--to=ross.lagerwall@citrix.com \
--cc=bob.liu@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).