Re: [PATCH v8 02/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping

From: "Jan Beulich" <JBeulich@suse.com>
To: Quan Xu <quan.xu@intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Feng Wu <feng.wu@intel.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Dario Faggioli <dario.faggioli@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH v8 02/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping
Date: Wed, 15 Jun 2016 02:42:00 -0600	[thread overview]
Message-ID: <576130F802000078000F524C@prv-mh.provo.novell.com> (raw)
In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28894B8E5E56@SHSMSX103.ccr.corp.intel.com>

>>> On 15.06.16 at 10:35, <quan.xu@intel.com> wrote:
> On June 15, 2016 4:22 PM, Tian, Kevin <kevin.tian@intel.com> wrote:
>> > From: Xu, Quan
>> > Sent: Wednesday, June 15, 2016 4:16 PM
>> >
>> > On June 15, 2016 3:45 PM, Jan Beulich <JBeulich@suse.com> wrote:
>> > > >>> On 15.06.16 at 03:54, <quan.xu@intel.com> wrote:
>> > > > Jan,
>> > > > Could you help me review patch 7?   Thanks.
>> > > > Then, I can send out next v9 soon and get started to focus on next
>> > > > patch set.
>> > >
>> > > That patch is fine now from my pov, feel free to stick my R-b on it.
>> > > I actually have it queued for committing already, pending an ARM ack
>> > > for patch 4 (which is why yesterday I committed only the first three
>> > > patches of that series); I didn't check yet which other acks may
>> > > still be missing on later patches, everything up to patch 8 is ready
>> > > to go in afaic, pending all necessary acks are in place.
>> > >
>> >
>> > Jan,
>> > thanks very much!!
>> > For patch 4, I will ping arm maintainer in that email.
>> >
>> >
>> >
>> > Kevin,
>> >     For patch 9, could you help me review it?  With your reply of
>> > http://lists.xenproject.org/archives/html/xen-devel/2016- 
>> 06/msg01842.html  ,
>> >    there is no issue doing so based on spec. I think what I do is
>> > changing ' iommu_rc / iommu_ret '  to ' context_rc / iotlb_rc '.
>> >    in this case, I wonder whether this can be fixed upon commit, then
>> > I am no need to send out v9.
>> >
>> 
>> Yes, no more comments except the naming:
>> 
>> Acked-by: Kevin Tian <kevin.tian@intel.com>
> 
> Jan,
> If there are no other problem, could you help me fix these naming issue upon 
> commit?  

I wouldn't want to do that. As said in an earlier reply, I have things
up to patch 8 queued for commit (which by implication means I'd
expect at least 9...11 to see another revision).

> Also for the comments,  you can change them as you like.

I'm not clear which comments you refer to here.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel