xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: jeremy@goop.org, jdelvare@suse.com, peterz@infradead.org,
	hpa@zytor.com, akataria@vmware.com, x86@kernel.org,
	rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org,
	chrisw@sous-sol.org, mingo@redhat.com, david.vrabel@citrix.com,
	Douglas_Warzecha@dell.com, pali.rohar@gmail.com,
	boris.ostrovsky@oracle.com, tglx@linutronix.de,
	linux@roeck-us.net
Subject: Re: [PATCH v5 2/6] virt, sched: add generic vcpu pinning support
Date: Wed, 15 Jun 2016 13:18:47 +0200	[thread overview]
Message-ID: <57613997.9090205__42202.3470317528$1465989613$gmane$org@suse.com> (raw)
In-Reply-To: <1459952266-3687-3-git-send-email-jgross@suse.com>

On 06/04/16 16:17, Juergen Gross wrote:
> Add generic virtualization support for pinning the current vcpu to a
> specified physical cpu. As this operation isn't performance critical
> (a very limited set of operations like BIOS calls and SMIs is expected
> to need this) just add a hypervisor specific indirection.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Could please some maintainer comment on this patch?


Juergen

> ---
> V4: move this patch some places up in the series
>      WARN_ONCE in case platform doesn't support pinning as requested by
>      Peter Zijlstra
>
> V3: use getc_cpu()/put_cpu() as suggested by David Vrabel
>
> V2: adapt to using workqueues
>      add include/linux/hypervisor.h to hide architecture specific stuff
>      from generic kernel code
>
> In case paravirt maintainers don't want to be responsible for
> include/linux/hypervisor.h I could take it.
> ---
>   MAINTAINERS                       |  1 +
>   arch/x86/include/asm/hypervisor.h |  4 ++++
>   arch/x86/kernel/cpu/hypervisor.c  | 11 +++++++++++
>   include/linux/hypervisor.h        | 17 +++++++++++++++++
>   kernel/smp.c                      |  1 +
>   kernel/up.c                       |  1 +
>   6 files changed, 35 insertions(+)
>   create mode 100644 include/linux/hypervisor.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 40eb1db..d3bde4f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8330,6 +8330,7 @@ S:	Supported
>   F:	Documentation/virtual/paravirt_ops.txt
>   F:	arch/*/kernel/paravirt*
>   F:	arch/*/include/asm/paravirt.h
> +F:	include/linux/hypervisor.h
>
>   PARIDE DRIVERS FOR PARALLEL PORT IDE DEVICES
>   M:	Tim Waugh <tim@cyberelk.net>
> diff --git a/arch/x86/include/asm/hypervisor.h b/arch/x86/include/asm/hypervisor.h
> index 055ea99..67942b6 100644
> --- a/arch/x86/include/asm/hypervisor.h
> +++ b/arch/x86/include/asm/hypervisor.h
> @@ -43,6 +43,9 @@ struct hypervisor_x86 {
>
>   	/* X2APIC detection (run once per boot) */
>   	bool		(*x2apic_available)(void);
> +
> +	/* pin current vcpu to specified physical cpu (run rarely) */
> +	void		(*pin_vcpu)(int);
>   };
>
>   extern const struct hypervisor_x86 *x86_hyper;
> @@ -56,6 +59,7 @@ extern const struct hypervisor_x86 x86_hyper_kvm;
>   extern void init_hypervisor(struct cpuinfo_x86 *c);
>   extern void init_hypervisor_platform(void);
>   extern bool hypervisor_x2apic_available(void);
> +extern void hypervisor_pin_vcpu(int cpu);
>   #else
>   static inline void init_hypervisor(struct cpuinfo_x86 *c) { }
>   static inline void init_hypervisor_platform(void) { }
> diff --git a/arch/x86/kernel/cpu/hypervisor.c b/arch/x86/kernel/cpu/hypervisor.c
> index 73d391a..ff108f8 100644
> --- a/arch/x86/kernel/cpu/hypervisor.c
> +++ b/arch/x86/kernel/cpu/hypervisor.c
> @@ -85,3 +85,14 @@ bool __init hypervisor_x2apic_available(void)
>   	       x86_hyper->x2apic_available &&
>   	       x86_hyper->x2apic_available();
>   }
> +
> +void hypervisor_pin_vcpu(int cpu)
> +{
> +	if (!x86_hyper)
> +		return;
> +
> +	if (x86_hyper->pin_vcpu)
> +		x86_hyper->pin_vcpu(cpu);
> +	else
> +		WARN_ONCE(1, "vcpu pinning requested but not supported!\n");
> +}
> diff --git a/include/linux/hypervisor.h b/include/linux/hypervisor.h
> new file mode 100644
> index 0000000..3fa5ef2
> --- /dev/null
> +++ b/include/linux/hypervisor.h
> @@ -0,0 +1,17 @@
> +#ifndef __LINUX_HYPEVISOR_H
> +#define __LINUX_HYPEVISOR_H
> +
> +/*
> + *	Generic Hypervisor support
> + *		Juergen Gross <jgross@suse.com>
> + */
> +
> +#ifdef CONFIG_HYPERVISOR_GUEST
> +#include <asm/hypervisor.h>
> +#else
> +static inline void hypervisor_pin_vcpu(int cpu)
> +{
> +}
> +#endif
> +
> +#endif /* __LINUX_HYPEVISOR_H */
> diff --git a/kernel/smp.c b/kernel/smp.c
> index 7416544..9388064 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -14,6 +14,7 @@
>   #include <linux/smp.h>
>   #include <linux/cpu.h>
>   #include <linux/sched.h>
> +#include <linux/hypervisor.h>
>
>   #include "smpboot.h"
>
> diff --git a/kernel/up.c b/kernel/up.c
> index 1760bf3..3ccee2b 100644
> --- a/kernel/up.c
> +++ b/kernel/up.c
> @@ -6,6 +6,7 @@
>   #include <linux/kernel.h>
>   #include <linux/export.h>
>   #include <linux/smp.h>
> +#include <linux/hypervisor.h>
>
>   int smp_call_function_single(int cpu, void (*func) (void *info), void *info,
>   				int wait)
>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-06-15 11:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1459952266-3687-1-git-send-email-jgross@suse.com>
2016-04-06 14:17 ` [PATCH v5 1/6] xen: sync xen header Juergen Gross
2016-04-06 14:17 ` [PATCH v5 2/6] virt, sched: add generic vcpu pinning support Juergen Gross
2016-04-06 14:17 ` [PATCH v5 3/6] smp: add function to execute a function synchronously on a cpu Juergen Gross
2016-04-06 14:17 ` [PATCH v5 4/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu Juergen Gross
2016-04-06 14:17 ` [PATCH v5 5/6] dcdbas: make use of smp_call_on_cpu() Juergen Gross
2016-04-06 14:17 ` [PATCH v5 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k Juergen Gross
     [not found] ` <1459952266-3687-4-git-send-email-jgross@suse.com>
2016-04-06 18:04   ` [PATCH v5 3/6] smp: add function to execute a function synchronously on a cpu Peter Zijlstra
2016-04-13  8:49 ` [PATCH v5 0/6] Support calling functions on dedicated physical cpu Juergen Gross
     [not found] ` <570E07FD.4030403@suse.com>
2016-05-17 11:21   ` Juergen Gross
     [not found] ` <1459952266-3687-7-git-send-email-jgross@suse.com>
2016-06-13 19:05   ` [PATCH v5 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k Pali Rohár
     [not found] ` <1459952266-3687-3-git-send-email-jgross@suse.com>
2016-06-15 11:18   ` Juergen Gross [this message]
     [not found] ` <1459952266-3687-6-git-send-email-jgross@suse.com>
2016-06-15 11:19   ` [PATCH v5 5/6] dcdbas: make use of smp_call_on_cpu() Juergen Gross
2016-06-20  8:40 ` [PATCH v5 0/6] Support calling functions on dedicated physical cpu Juergen Gross
2016-06-27 10:34 ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='57613997.9090205__42202.3470317528$1465989613$gmane$org@suse.com' \
    --to=jgross@suse.com \
    --cc=Douglas_Warzecha@dell.com \
    --cc=akataria@vmware.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=chrisw@sous-sol.org \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@redhat.com \
    --cc=pali.rohar@gmail.com \
    --cc=peterz@infradead.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH v5 2/6] virt, sched: add generic vcpu pinning support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).