From: "Jan Beulich" <JBeulich@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>, xen-devel@lists.xen.org
Subject: Re: Xen-unstable 4.8: HVM domain_crash called from emulate.c:144 RIP: c000:[<000000000000336a>]
Date: Wed, 15 Jun 2016 08:39:03 -0600 [thread overview]
Message-ID: <576184A702000078000F5639@prv-mh.provo.novell.com> (raw)
In-Reply-To: <57616717.80601@oracle.com>
>>> On 15.06.16 at 16:32, <boris.ostrovsky@oracle.com> wrote:
> So perhaps we shouldn't latch data for anything over page size.
But why? What we latch is the start of the accessed range, so
the repeat count shouldn't matter?
> Something like this (it seems to work):
I'm rather hesitant to take a change like this without understanding
why this helps nor whether this really deals with the problem in all
cases.
Jan
> --- a/xen/arch/x86/hvm/emulate.c
> +++ b/xen/arch/x86/hvm/emulate.c
> @@ -1195,7 +1195,8 @@ static int hvmemul_rep_movs(
> if ( rc != X86EMUL_OKAY )
> return rc;
>
> - latch_linear_to_phys(vio, saddr, sgpa, 0);
> + if ( *reps * bytes_per_rep <= PAGE_SIZE)
> + latch_linear_to_phys(vio, saddr, sgpa, 0);
> }
>
> bytes = PAGE_SIZE - (daddr & ~PAGE_MASK);
> @@ -1214,7 +1215,8 @@ static int hvmemul_rep_movs(
> if ( rc != X86EMUL_OKAY )
> return rc;
>
> - latch_linear_to_phys(vio, daddr, dgpa, 1);
> + if ( *reps * bytes_per_rep <= PAGE_SIZE)
> + latch_linear_to_phys(vio, daddr, dgpa, 1);
> }
>
> /* Check for MMIO ops */
> @@ -1339,7 +1341,8 @@ static int hvmemul_rep_stos(
> if ( rc != X86EMUL_OKAY )
> return rc;
>
> - latch_linear_to_phys(vio, addr, gpa, 1);
> + if ( *reps * bytes_per_rep <= PAGE_SIZE)
> + latch_linear_to_phys(vio, addr, gpa, 1);
> }
>
> /* Check for MMIO op */
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-15 14:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 23:49 Xen-unstable 4.8: HVM domain_crash called from emulate.c:144 RIP: c000:[<000000000000336a>] linux
2016-06-15 8:29 ` Jan Beulich
2016-06-15 8:57 ` Sander Eikelenboom
2016-06-15 9:38 ` Sander Eikelenboom
2016-06-15 10:12 ` Jan Beulich
2016-06-15 12:00 ` Sander Eikelenboom
2016-06-15 12:48 ` Jan Beulich
2016-06-15 13:58 ` Sander Eikelenboom
2016-06-15 14:07 ` Jan Beulich
2016-06-15 14:20 ` Boris Ostrovsky
2016-06-15 14:32 ` Boris Ostrovsky
2016-06-15 14:39 ` Jan Beulich [this message]
2016-06-15 14:56 ` Boris Ostrovsky
2016-06-15 15:22 ` Jan Beulich
2016-06-15 15:29 ` Paul Durrant
2016-06-15 15:43 ` Jan Beulich
2016-06-15 15:46 ` Paul Durrant
2016-06-15 15:54 ` Jan Beulich
2016-06-15 16:46 ` Boris Ostrovsky
2016-06-16 8:03 ` Jan Beulich
2016-06-15 14:35 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576184A702000078000F5639@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux@eikelenboom.it \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).