xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Juergen Gross <JGross@suse.com>
Cc: anthony.perard@citrix.com,
	xen-devel <xen-devel@lists.xenproject.org>,
	sstabellini@kernel.org, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix
Date: Thu, 16 Jun 2016 04:54:19 -0600	[thread overview]
Message-ID: <5762A17B02000078000F59F3__43395.343682687$1466074523$gmane$org@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1466071320-10964-1-git-send-email-jgross@suse.com>

>>> On 16.06.16 at 12:02, <JGross@suse.com> wrote:
> In case the word size of the domU and qemu running the qdisk backend
> differ BLKIF_OP_DISCARD will not work reliably, as the request
> structure in the ring have different layouts for different word size.
> 
> Correct this by copying the request structure in case of different
> word size element by element in the BLKIF_OP_DISCARD case, too.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

With the indentation (tabs vs blanks) fixed
Reviewed-by: Jan Beulich <jbeulich@suse.com>

And maybe ...

> @@ -82,7 +98,7 @@ static inline void blkif_get_x86_32_req(blkif_request_t *dst, blkif_x86_32_reque
>  	/* Prevent the compiler from using src->... instead. */
>  	barrier();
>  	if (dst->operation == BLKIF_OP_DISCARD) {
> -		struct blkif_request_discard *s = (void *)src;
> +                struct blkif_x86_32_request_discard *s = (void *)src;

... it would also be worth adding const here and ...

> @@ -105,7 +121,7 @@ static inline void blkif_get_x86_64_req(blkif_request_t *dst, blkif_x86_64_reque
>  	/* Prevent the compiler from using src->... instead. */
>  	barrier();
>  	if (dst->operation == BLKIF_OP_DISCARD) {
> -		struct blkif_request_discard *s = (void *)src;
> +                struct blkif_x86_64_request_discard *s = (void *)src;

... here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-16 10:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 10:02 Juergen Gross
2016-06-16 10:54 ` Jan Beulich [this message]
     [not found] ` <5762A17B02000078000F59F3@suse.com>
2016-06-16 11:04   ` Juergen Gross
2016-06-16 11:17     ` Jan Beulich
2016-06-16 13:07     ` Stefano Stabellini
     [not found]     ` <alpine.DEB.2.10.1606161407240.18449@sstabellini-ThinkPad-X260>
2016-06-16 13:49       ` Juergen Gross
     [not found]       ` <5762AE7B.4030402@suse.com>
2016-06-17 16:07         ` Stefano Stabellini
2016-06-16 11:24 ` [Xen-devel] " Paul Durrant
2016-06-16 12:18   ` Juergen Gross
2016-06-16 12:23     ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='5762A17B02000078000F59F3__43395.343682687$1466074523$gmane$org@prv-mh.provo.novell.com' \
    --to=jbeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=anthony.perard@citrix.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).