From: "Jan Beulich" <JBeulich@suse.com>
To: Juergen Gross <JGross@suse.com>
Cc: anthony.perard@citrix.com,
xen-devel <xen-devel@lists.xenproject.org>,
sstabellini@kernel.org, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix
Date: Thu, 16 Jun 2016 05:17:17 -0600 [thread overview]
Message-ID: <5762A6DD02000078000F5A44__31418.1724716493$1466075903$gmane$org@prv-mh.provo.novell.com> (raw)
In-Reply-To: <576287AE.4060401@suse.com>
>>> On 16.06.16 at 13:04, <JGross@suse.com> wrote:
> On 16/06/16 12:54, Jan Beulich wrote:
>>>>> On 16.06.16 at 12:02, <JGross@suse.com> wrote:
>>> In case the word size of the domU and qemu running the qdisk backend
>>> differ BLKIF_OP_DISCARD will not work reliably, as the request
>>> structure in the ring have different layouts for different word size.
>>>
>>> Correct this by copying the request structure in case of different
>>> word size element by element in the BLKIF_OP_DISCARD case, too.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>
>> With the indentation (tabs vs blanks) fixed
>
> Hmm, qemu coding style is to use blanks. I could:
> a) leave the patch as is (changed lines indented with blanks)
> b) use tabs to indent (style of the modified file up to now)
> c) change the style of the file in this patch
> d) change the style of the file in a separate patch
>
> Any preferences?
I'd say a) is not an option, but beyond that I think this needs to be
answered by the qemu maintainers.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-16 11:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 10:02 [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix Juergen Gross
2016-06-16 10:54 ` Jan Beulich
[not found] ` <5762A17B02000078000F59F3@suse.com>
2016-06-16 11:04 ` Juergen Gross
2016-06-16 11:17 ` Jan Beulich [this message]
2016-06-16 13:07 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.10.1606161407240.18449@sstabellini-ThinkPad-X260>
2016-06-16 13:49 ` Juergen Gross
[not found] ` <5762AE7B.4030402@suse.com>
2016-06-17 16:07 ` Stefano Stabellini
2016-06-16 11:24 ` [Xen-devel] " Paul Durrant
2016-06-16 12:18 ` Juergen Gross
2016-06-16 12:23 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='5762A6DD02000078000F5A44__31418.1724716493$1466075903$gmane$org@prv-mh.provo.novell.com' \
--to=jbeulich@suse.com \
--cc=JGross@suse.com \
--cc=anthony.perard@citrix.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).