xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@citrix.com>
To: Philipp Hahn <hahn@univention.de>
Cc: "Nico Stöckigt" <Stoeckigt@univention.de>,
	"Stefan Bader" <stefan.bader@canonical.com>,
	"xen-devel@lists.xen.org" <Xen-devel@lists.xen.org>
Subject: Xen 4.1 maintenance? (Was Re: [xen-4.1.6.1] SIGSEGV libxc/xc_save_domain.c: p2m_size >> configured_ram_size)
Date: Fri, 17 Jun 2016 10:31:33 +0100	[thread overview]
Message-ID: <5763C375.3050809@citrix.com> (raw)
In-Reply-To: <575E9594.9010708@univention.de>

On 13/06/16 12:14, Philipp Hahn wrote:
> Am 13.06.2016 um 12:15 schrieb George Dunlap:
>> On Fri, Jun 10, 2016 at 4:22 PM, Philipp Hahn <hahn@univention.de> wrote:
>>> while trying to live migrate some VMs from an xen-4.1.6.1 host "xc_save"
>>> crashes with a segmentation fault in tools/libxc/xc_domain_save.c:1141
>>>>         /*
>>>>          * Quick belt and braces sanity check.
>>>>          */
>>>>         for ( i = 0; i < dinfo->p2m_size; i++ )
>>>>         {
>>>>             mfn = pfn_to_mfn(i);
>>>>             if( (mfn != INVALID_P2M_ENTRY) && (mfn_to_pfn(mfn) != i) )
>>>                                                  ^^^^^^^^^^^^^^^
>>> due to a de-reference through
>>>> #define pfn_to_mfn(_pfn)                                            \
>>>>   ((xen_pfn_t) ((dinfo->guest_width==8)                               \
>>>>                 ? (((uint64_t *)ctx->live_p2m)[(_pfn)])                  \
>>>>                 : ((((uint32_t *)ctx->live_p2m)[(_pfn)]) == 0xffffffffU  \
>>>>                    ? (-1UL) : (((uint32_t *)ctx->live_p2m)[(_pfn)]))))
> ...
>> Given that 4.1 is long out of support, we won't be making a proper fix
>> in-tree (since it will never be released).
> 
> I know that 4.1 is EOL.
> I'm aware of Ubuntu still having xen-4.1 in one of their LTS versions
> (Precise) and its also in Debian-oldstable, which a lot people (us
> included) still use. I would prefer to update, but I can for reasons
> outside my direct control.
> 
> I'm already working with Stefan Bader from Canonical to backport most of
> the XSAs to 4.1, so there already exists a "better" version outside of
> the official Xen repositories.

Philipp / Stefan -- if there really is a large following of people still
using 4.1, would it make sense to have one or both of you step up and
maintain an official branch on xenbits?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-17  9:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 15:22 [xen-4.1.6.1] SIGSEGV libxc/xc_save_domain.c: p2m_size >> configured_ram_size Philipp Hahn
2016-06-13 10:15 ` George Dunlap
2016-06-13 11:14   ` Philipp Hahn
2016-06-17  9:31     ` George Dunlap [this message]
2016-06-29  9:46       ` Xen 4.1 maintenance? (Was Re: [xen-4.1.6.1] SIGSEGV libxc/xc_save_domain.c: p2m_size >> configured_ram_size) Stefan Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5763C375.3050809@citrix.com \
    --to=george.dunlap@citrix.com \
    --cc=Stoeckigt@univention.de \
    --cc=Xen-devel@lists.xen.org \
    --cc=hahn@univention.de \
    --cc=stefan.bader@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).