xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] hvmloader: don't hard-code IO-APIC parameters
Date: Fri, 17 Jun 2016 04:23:24 -0600	[thread overview]
Message-ID: <5763EBBC02000078000F6138@prv-mh.provo.novell.com> (raw)
In-Reply-To: <59f231ae-60a2-3e0f-cec2-b0b515ff50ce@citrix.com>

>>> On 17.06.16 at 12:05, <andrew.cooper3@citrix.com> wrote:
> On 16/06/16 10:40, Jan Beulich wrote:
>> The IO-APIC address has variable bits determined by the PCI-to-ISA
>> bridge, and the IO-APIC version should be read from the IO-APIC. (Note
>> that there's still implicit rather than explicit agreement on the
>> IO-APIC base address between qemu and the hypervisor.)
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> The status quo is not great, and I can see why you want to improve it.
> 
> However, I think that this is not the way to do that.  It ties HVMLoader
> to the PIIX4 board in Qemu, and will break attempts to use Q35 or
> something else.  (In Q35, the IO-APIC decode address comes from Chipset
> Configuration Register, rather than ISA device config space).

hvmloader is already tied to PIIX4, and enabling Q35 will, among
other things, require hvmloader to become aware of that chipset.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-06-17 10:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16  9:33 [PATCH 0/2] x86: hvmloader improvements Jan Beulich
2016-06-16  9:40 ` [PATCH 1/2] hvmloader: limit CPUs exposed to guests Jan Beulich
2016-06-16 15:09   ` Boris Ostrovsky
2016-06-16 15:25     ` Jan Beulich
2016-06-16 15:37       ` Boris Ostrovsky
2016-06-16 16:04         ` Jan Beulich
2016-06-16 16:38           ` Boris Ostrovsky
2016-06-17  9:40   ` Andrew Cooper
2016-06-16  9:40 ` [PATCH 2/2] hvmloader: don't hard-code IO-APIC parameters Jan Beulich
2016-06-16 16:49   ` Boris Ostrovsky
2016-06-17  6:00     ` Jan Beulich
2016-06-17 11:51       ` Boris Ostrovsky
2016-06-17 14:26         ` Jan Beulich
2016-06-17 10:05   ` Andrew Cooper
2016-06-17 10:23     ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5763EBBC02000078000F6138@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH 2/2] hvmloader: don'\''t hard-code IO-APIC parameters' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).