From: Julien Grall <julien.grall@arm.com> To: Corneliu ZUZU <czuzu@bitdefender.com>, xen-devel@lists.xen.org Cc: Kevin Tian <kevin.tian@intel.com>, Stefano Stabellini <sstabellini@kernel.org>, Jan Beulich <jbeulich@suse.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul.durrant@citrix.com>, Tamas K Lengyel <tamas@tklengyel.com>, Jun Nakajima <jun.nakajima@intel.com> Subject: Re: [PATCH 3/7] vm-event: introduce vm_event_vcpu_enter Date: Fri, 17 Jun 2016 14:22:10 +0100 [thread overview] Message-ID: <5763F982.7050109@arm.com> (raw) In-Reply-To: <81e55cd7-10d8-2dcd-f36d-e43823fa2d08@bitdefender.com> Hello, On 17/06/16 12:40, Corneliu ZUZU wrote: > On 6/17/2016 11:55 AM, Julien Grall wrote: >> On 16/06/16 15:08, Corneliu ZUZU wrote: >>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c >>> index d31f821..ba248c8 100644 >>> --- a/xen/arch/arm/domain.c >>> +++ b/xen/arch/arm/domain.c >>> @@ -19,6 +19,7 @@ >>> #include <xen/errno.h> >>> #include <xen/bitops.h> >>> #include <xen/grant_table.h> >>> +#include <xen/vm_event.h> >>> >>> #include <asm/current.h> >>> #include <asm/event.h> >>> @@ -251,6 +252,8 @@ static void schedule_tail(struct vcpu *prev) >>> >>> ctxt_switch_to(current); >>> >>> + vm_event_vcpu_enter(current); >>> + >>> local_irq_enable(); >>> >>> context_saved(prev); >>> @@ -296,7 +299,7 @@ void context_switch(struct vcpu *prev, struct >>> vcpu *next) >>> >>> void continue_running(struct vcpu *same) >>> { >>> - /* Nothing to do */ >>> + vm_event_vcpu_enter(same); >>> } >>> >>> void sync_local_execstate(void) >> >> From my understanding of the commit message, vm_event_vcpu_enter >> should be called before returning to the guest. The scheduling >> functions are not called every-time Xen is returning to the guest. So >> if you want to do every time Xen is re-entering to the guest, then >> this should be done in leave_hypervisor_tail. >> >> Regards, >> > > Which is also done, vm_event_vcpu_enter is called from > leave_hypervisor_tail as well. Sorry I did not spot this one. > Are you saying that calling from leave_hypervisor_tail is enough and > that the schedule_tail call is not necessary? leave_hypervisor_tail will always be called before returning to the guest. So a call to vm_event_vcpu_enter in this function will be sufficient. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-17 13:22 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-16 14:04 [PATCH 0/7] vm-event: Implement ARM support for control-register writes Corneliu ZUZU 2016-06-16 14:06 ` [PATCH 1/7] minor (formatting) fixes Corneliu ZUZU 2016-06-16 14:24 ` Jan Beulich 2016-06-16 19:19 ` Corneliu ZUZU 2016-06-17 7:06 ` Jan Beulich 2016-06-17 10:46 ` Corneliu ZUZU 2016-06-16 16:02 ` Tamas K Lengyel 2016-06-17 8:33 ` Corneliu ZUZU 2016-06-17 8:36 ` Razvan Cojocaru 2016-06-17 9:29 ` Andrew Cooper 2016-06-17 9:35 ` Jan Beulich 2016-06-17 9:33 ` Jan Beulich 2016-06-17 9:36 ` Razvan Cojocaru 2016-06-17 9:40 ` Jan Beulich 2016-06-17 9:42 ` Razvan Cojocaru 2016-06-17 19:05 ` Tamas K Lengyel 2016-06-16 14:07 ` [PATCH 2/7] vm-event: VM_EVENT_FLAG_DENY requires VM_EVENT_FLAG_VCPU_PAUSED Corneliu ZUZU 2016-06-16 16:11 ` Tamas K Lengyel 2016-06-17 8:43 ` Corneliu ZUZU 2016-06-21 11:26 ` Corneliu ZUZU 2016-06-21 15:09 ` Tamas K Lengyel 2016-06-22 8:34 ` Corneliu ZUZU 2016-06-16 14:08 ` [PATCH 3/7] vm-event: introduce vm_event_vcpu_enter Corneliu ZUZU 2016-06-16 14:51 ` Jan Beulich 2016-06-16 20:10 ` Corneliu ZUZU 2016-06-16 20:33 ` Razvan Cojocaru 2016-06-17 10:41 ` Corneliu ZUZU 2016-06-17 7:17 ` Jan Beulich 2016-06-17 11:13 ` Corneliu ZUZU 2016-06-17 11:27 ` Jan Beulich 2016-06-17 12:13 ` Corneliu ZUZU 2016-06-16 16:17 ` Tamas K Lengyel 2016-06-17 9:19 ` Corneliu ZUZU 2016-06-17 8:55 ` Julien Grall 2016-06-17 11:40 ` Corneliu ZUZU 2016-06-17 13:22 ` Julien Grall [this message] 2016-06-16 14:09 ` [PATCH 4/7] vm-event/x86: use vm_event_vcpu_enter properly Corneliu ZUZU 2016-06-16 15:00 ` Jan Beulich 2016-06-16 20:20 ` Corneliu ZUZU 2016-06-17 7:20 ` Jan Beulich 2016-06-17 11:23 ` Corneliu ZUZU 2016-06-16 16:27 ` Tamas K Lengyel 2016-06-17 9:24 ` Corneliu ZUZU 2016-06-16 14:10 ` [PATCH 5/7] x86: replace monitor_write_data.do_write with enum Corneliu ZUZU 2016-06-16 14:12 ` [PATCH 6/7] vm-event/arm: move hvm_event_cr->common vm_event_monitor_cr Corneliu ZUZU 2016-06-16 15:16 ` Jan Beulich 2016-06-17 8:25 ` Corneliu ZUZU 2016-06-17 8:38 ` Jan Beulich 2016-06-17 11:31 ` Corneliu ZUZU 2016-06-21 7:08 ` Corneliu ZUZU 2016-06-21 7:20 ` Jan Beulich 2016-06-21 15:22 ` Tamas K Lengyel 2016-06-22 6:33 ` Jan Beulich 2016-06-16 16:55 ` Tamas K Lengyel 2016-06-17 10:37 ` Corneliu ZUZU 2016-06-16 14:13 ` [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events Corneliu ZUZU 2016-06-16 14:26 ` Julien Grall 2016-06-16 19:24 ` Corneliu ZUZU 2016-06-16 21:28 ` Julien Grall 2016-06-17 11:46 ` Corneliu ZUZU 2016-06-16 16:49 ` Julien Grall 2016-06-17 10:36 ` Corneliu ZUZU 2016-06-17 13:18 ` Julien Grall 2016-06-22 16:35 ` Corneliu ZUZU 2016-06-22 17:17 ` Julien Grall 2016-06-22 18:39 ` Corneliu ZUZU 2016-06-22 19:37 ` Corneliu ZUZU 2016-06-22 19:41 ` Julien Grall 2016-06-23 5:31 ` Corneliu ZUZU 2016-06-23 5:49 ` Corneliu ZUZU 2016-06-23 11:11 ` Julien Grall 2016-06-24 9:32 ` Corneliu ZUZU 2016-06-23 11:00 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5763F982.7050109@arm.com \ --to=julien.grall@arm.com \ --cc=andrew.cooper3@citrix.com \ --cc=czuzu@bitdefender.com \ --cc=george.dunlap@eu.citrix.com \ --cc=jbeulich@suse.com \ --cc=jun.nakajima@intel.com \ --cc=kevin.tian@intel.com \ --cc=paul.durrant@citrix.com \ --cc=rcojocaru@bitdefender.com \ --cc=sstabellini@kernel.org \ --cc=tamas@tklengyel.com \ --cc=xen-devel@lists.xen.org \ --subject='Re: [PATCH 3/7] vm-event: introduce vm_event_vcpu_enter' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).