From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Doug Goldstein <cardoe@cardoe.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well
Date: Mon, 20 Jun 2016 04:11:31 -0600 [thread overview]
Message-ID: <5767DD7302000078000F694F@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20160620090926.GJ28116@citrix.com>
>>> On 20.06.16 at 11:09, <wei.liu2@citrix.com> wrote:
> On Fri, Jun 17, 2016 at 08:45:39AM -0600, Jan Beulich wrote:
>> >>> On 17.06.16 at 15:50, <andrew.cooper3@citrix.com> wrote:
>> > On 17/06/16 12:05, Wei Liu wrote:
>> >> @@ -182,6 +183,28 @@ static int __init hvm_enable(void)
>> >> if ( !opt_altp2m_enabled )
>> >> hvm_funcs.altp2m_supported = 0;
>> >>
>> >> + if ( opt_hvm_fep )
>> >> + {
>> >> + unsigned int i, j;
>> >> +
>> >> + printk("**********************************************\n");
>> >> + printk("******* WARNING: HVM FORCED EMULATION PREFIX IS
> AVAILABLE\n");
>> >> + printk("******* This option is *ONLY* intended to aid testing of
> Xen.\n");
>> >> + printk("******* It has implications on the security of the
> system.\n");
>> >> + printk("******* Please *DO NOT* use this in production.\n");
>> >> + printk("**********************************************\n");
>> >> + for ( i = 0; i < 3; i++ )
>> >> + {
>> >> + printk("%u... ", 3 - i);
>> >> + for ( j = 0; j < 100; j++ )
>> >> + {
>> >> + process_pending_softirqs();
>> >> + mdelay(10);
>> >> + }
>> >> + }
>> >
>> > I would drop this 3s wait, and I plan to drop it from sync_console as
>> > well. It isn't of any practical use, even if you are watching the
>> > serial console on boot, and just leads to an unnecessary delay. Worse,
>> > the two delays are cumulative.
>>
>> I think the delay serves a purpose (for the messages to not scroll by
>> unnoticed), but I do appreciate that having two such delays is not
>> really desirable. Considering that I would also like these messages to
>> go into .init.rodata (also those for the sync_console warning), perhaps
>> worth a little bit of abstraction?
>
> What is the plan here?
I didn't see a response from Andrew yet; I continue to think some
delay ought to be there.
> Should I keep or remove the delay? Do you want me to refactor things?
If you're up to some refactoring, that'd be appreciated.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-20 10:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 11:05 [PATCH v2 0/2] Make hvm_fep available to non-debug build Wei Liu
2016-06-17 11:05 ` [PATCH v2 1/2] xen/kernel: document 'C' in print_tainted Wei Liu
2016-06-17 11:05 ` [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well Wei Liu
2016-06-17 11:34 ` Jan Beulich
2016-06-17 13:35 ` Wei Liu
2016-06-17 13:51 ` Andrew Cooper
2016-06-17 14:28 ` Jan Beulich
2016-06-17 14:32 ` Wei Liu
2016-06-17 14:40 ` Jan Beulich
2016-06-17 14:44 ` Wei Liu
2016-06-17 14:55 ` Jan Beulich
2016-06-17 14:59 ` Wei Liu
2016-06-17 13:50 ` Andrew Cooper
2016-06-17 14:45 ` Jan Beulich
2016-06-20 9:09 ` Wei Liu
2016-06-20 10:11 ` Jan Beulich [this message]
2016-06-20 13:19 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767DD7302000078000F694F@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).