From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH] x86: compact supposedly unused entry point code Date: Mon, 20 Jun 2016 05:04:30 -0600 Message-ID: <5767E9DE02000078000F69D3@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__Part3B0D06AE.1__=" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEx0P-0004gQ-Ca for xen-devel@lists.xenproject.org; Mon, 20 Jun 2016 11:04:37 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel Cc: Andrew Cooper List-Id: xen-devel@lists.xenproject.org This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__Part3B0D06AE.1__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline No point in aligning entry points which aren't supposed to be used anyway. Signed-off-by: Jan Beulich --- TBD: Might consider simply using "andq $-15,%rsp", delivering an uninitialized error code (which shouldn't matter). --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -866,11 +866,11 @@ autogen_stubs: /* Automatically generate =20 vec =3D 0 .rept NR_VECTORS - ALIGN =20 /* Common interrupts, heading towards do_IRQ(). */ .if vec >=3D FIRST_DYNAMIC_VECTOR && vec !=3D HYPERCALL_VECTOR && = vec !=3D LEGACY_SYSCALL_VECTOR =20 + ALIGN 1: pushq $0 movb $vec,4(%rsp) jmp common_interrupt --=__Part3B0D06AE.1__= Content-Type: text/plain; name="x86-compact-unknown-entry-points.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="x86-compact-unknown-entry-points.patch" x86: compact supposedly unused entry point code =0A=0ANo point in aligning = entry points which aren't supposed to be used=0Aanyway.=0A=0ASigned-off-by:= Jan Beulich =0A---=0ATBD: Might consider simply using = "andq $-15,%rsp", delivering an=0Auninitialized error code (which = shouldn't matter).=0A=0A--- a/xen/arch/x86/x86_64/entry.S=0A+++ b/xen/arch/= x86/x86_64/entry.S=0A@@ -866,11 +866,11 @@ autogen_stubs: /* Automatically = generate=0A =0A vec =3D 0=0A .rept NR_VECTORS=0A- = ALIGN=0A =0A /* Common interrupts, heading towards do_IRQ(). */=0A = .if vec >=3D FIRST_DYNAMIC_VECTOR && vec !=3D HYPERCALL_VECTOR && = vec !=3D LEGACY_SYSCALL_VECTOR=0A =0A+ ALIGN=0A 1: pushq $0=0A = movb $vec,4(%rsp)=0A jmp common_interrupt=0A --=__Part3B0D06AE.1__= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --=__Part3B0D06AE.1__=--