From: Julien Grall <julien.grall@arm.com>
To: shankerd@codeaurora.org,
xen-devel <xen-devel@lists.xensource.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Philip Elcan <pelcan@codeaurora.org>,
Vikram Sethi <vikrams@codeaurora.org>
Subject: Re: [PATCH 0/8] Add support for parsing per CPU Redistributor entry
Date: Tue, 21 Jun 2016 15:44:58 +0100 [thread overview]
Message-ID: <576952EA.1090503@arm.com> (raw)
In-Reply-To: <57694C5B.8040308@codeaurora.org>
On 21/06/16 15:16, Shanker Donthineni wrote:
> On 06/21/2016 08:50 AM, Julien Grall wrote:
>> On 21/06/16 14:37, Shanker Donthineni wrote:
>>> On 06/21/2016 04:28 AM, Julien Grall wrote:
>>>> On 19/06/16 00:45, Shanker Donthineni wrote:
>>>>> The current driver doesn't support parsing Redistributor entries that
>>>>> are described in the MADT GICC table. Not all the GIC implementors
>>>>> places the Redistributor regions in the always-on power domain. On
>>>>> systems, the UEFI firmware should describe Redistributor base address
>>>>> in the associated GIC CPU Interface (GICC) instead of GIC
>> Redistributor
>>>>> (GICR) table.
>>>>>
>>>>> The maximum number of mmio handlers and struct vgic_rdist_region
>>>>> that holds Redistributor addresses are allocated through a static
>>>>> array with hardcoded size. I don't think this is the right approach
>>>>> and is not scalable for implementing features like this. I have
>>>>> decided to convert static to dynamic allocation based on comments
>>>>> from the below link.
>>>>>
>>>>> https://patchwork.kernel.org/patch/9163435/
>>>>
>>>> You addressed only one part of my comment. This series increases the
>>>> number of I/O handlers but the lookup is still linear (see handle_mmio
>>>> in arch/arm/io.c).
>>>>
>>> I agree with you, we need to bring binary search algorithm similar to
>>> Linux KVM code. I want to keep it this change outside of this patchset.
>>
>> This should be a prerequisite of this series then, not a follow-up.
>>
> For the functionality and correctness purpose we don't need this change
> immediately.
> We are not able to boot XEN on Qualcomm Technologies because of not
> supporting
> GICC table parsing for GICR address.
>
> I am okay to wait for my patchset if someone adding bseach look ups for
> mmio handlers.
I am not aware of anyone planning to add bsearch.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-21 14:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 23:45 [PATCH 0/8] Add support for parsing per CPU Redistributor entry Shanker Donthineni
2016-06-18 23:45 ` [PATCH 1/8] arm/gic-v3: Add a separate function for mapping GICD region Shanker Donthineni
2016-06-21 9:42 ` Julien Grall
2016-06-18 23:45 ` [PATCH 2/8] arm/gic-v3: Fold GICR subtable parsing into a new function Shanker Donthineni
2016-06-21 10:17 ` Julien Grall
2016-06-21 14:02 ` Shanker Donthineni
2016-06-18 23:45 ` [PATCH 3/8] arm/gic-v3: Parse per-cpu redistributor entry in GICC subtable Shanker Donthineni
2016-06-21 10:16 ` Julien Grall
2016-06-21 13:52 ` Shanker Donthineni
2016-06-22 13:06 ` Julien Grall
2016-06-18 23:45 ` [PATCH 4/8] xen/arm: vgic: Use dynamic memory allocation for vgic_rdist_region Shanker Donthineni
2016-06-21 10:26 ` Julien Grall
2016-06-18 23:45 ` [PATCH 5/8] arm/gic-v3: Remove an unused macro MAX_RDIST_COUNT Shanker Donthineni
2016-06-18 23:45 ` [PATCH 6/8] arm: vgic: Split vgic_domain_init() functionality into two functions Shanker Donthineni
2016-06-21 10:49 ` Julien Grall
2016-06-21 14:36 ` Shanker Donthineni
2016-06-21 14:48 ` Julien Grall
2016-06-21 15:09 ` Shanker Donthineni
2016-06-18 23:45 ` [PATCH 7/8] arm/mmio: Use separate memory allocation for mmio handlers Shanker Donthineni
2016-06-18 23:45 ` [PATCH 8/8] arm/vgic: Change fixed number of mmio handlers to variable number Shanker Donthineni
2016-06-21 9:28 ` [PATCH 0/8] Add support for parsing per CPU Redistributor entry Julien Grall
2016-06-21 13:37 ` Shanker Donthineni
2016-06-21 13:50 ` Julien Grall
2016-06-21 14:16 ` Shanker Donthineni
2016-06-21 14:44 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576952EA.1090503@arm.com \
--to=julien.grall@arm.com \
--cc=pelcan@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=vikrams@codeaurora.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).