Re: [PATCH v2] xen: arm: Update arm64 image header

[Julien Grall <julien.grall@arm.com>]

Hi Konrad,

On 22/06/16 14:30, Konrad Rzeszutek Wilk wrote:
> On Wed, Jun 22, 2016 at 10:59:19AM +0200, Dirk Behme wrote:
>> With the Linux kernel commits
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=4370eec05a887b0cd4392cd5dc5b2713174745c0
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Documentation/arm64/booting.txt?id=a2c1d73b94ed49f5fac12e95052d7b140783f800
>>
>> the arm64 image header changed. While the size of the header isn't changed,
>> some members have changed their usage.
>>
>> Update Xen to this updated image header.
>>
>> The main changes are that the first magic is gone and that there is an
>> image size, now.
>>
>> In case we read a size != 0, let's use this image size, now. This does
>> allow us to check if the kernel Image is larger than the size given in
>> the device tree, too.
>>
>> Additionally, add an error message if the magic is not found. This might
>> be the case with kernel's < 3.12 prior to
>
> Don't you want to still check for those kernels and use them?

The support of Xen for ARM64 in Linux has been added in Linux 3.11, so 
only one release will not work with Xen 4.8 and onwards. Given that this 
is not a long-term support I think it is fine to drop it. Note that 3.12 
is an LTS [1]. Stefano what do you think?

Dirk, I think your commit message will need more background similar to 
what I wrote above and in an answer to the previous version.

Cheers,

[1] https://www.kernel.org/category/releases.html

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel