From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] libxl: fix an error path that uses uninitialised rc in libxl_set_memory_target Date: Wed, 22 Jun 2016 07:53:56 -0600 Message-ID: <576AB49402000078000F7B56@prv-mh.provo.novell.com> References: <1465740590-21337-1-git-send-email-wei.liu2@citrix.com> <576AA79402000078000F7AC6@prv-mh.provo.novell.com> <20160622134704.GE1790@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFibS-0005Qh-AG for xen-devel@lists.xenproject.org; Wed, 22 Jun 2016 13:54:02 +0000 In-Reply-To: <20160622134704.GE1790@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: George Dunlap , Paulina Szubarczyk , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDIyLjA2LjE2IGF0IDE1OjQ3LCA8d2VpLmxpdTJAY2l0cml4LmNvbT4gd3JvdGU6Cj4g T24gV2VkLCBKdW4gMjIsIDIwMTYgYXQgMDY6NTg6MjhBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4+ID4+PiBPbiAxMi4wNi4xNiBhdCAxNjowOSwgPHdlaS5saXUyQGNpdHJpeC5jb20+IHdy b3RlOgo+PiA+IC0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPj4gPiArKysgYi90b29scy9saWJ4 bC9saWJ4bC5jCj4+ID4gQEAgLTQ5MjcsMTAgKzQ5MjcsMTIgQEAgcmV0cnlfdHJhbnNhY3Rpb246 Cj4+ID4gIAo+PiA+ICAgICAgdGFyZ2V0ID0gbGlieGxfX3hzX3JlYWQoZ2MsIHQsIEdDU1BSSU5U RigiJXMvbWVtb3J5L3RhcmdldCIsIGRvbXBhdGgpKTsKPj4gPiAgICAgIGlmICghdGFyZ2V0ICYm ICFkb21pZCkgewo+PiA+IC0gICAgICAgIGlmICgheHNfdHJhbnNhY3Rpb25fZW5kKGN0eC0+eHNo LCB0LCAxKSkKPj4gPiArICAgICAgICBpZiAoIXhzX3RyYW5zYWN0aW9uX2VuZChjdHgtPnhzaCwg dCwgMSkpIHsKPj4gPiArICAgICAgICAgICAgcmMgPSBFUlJPUl9GQUlMOwo+PiAKPj4gSSdtIHNv cnJ5IGZvciBub3RpY2luZyB0aGlzIG9ubHkgbm93IC0gaXMgRVJST1JfRkFJTCB0aGUgcmlnaHQg dGhpbmcKPj4gdG8gdXNlIGhlcmUsIGNvbnNpZGVyaW5nIGhvdyB0aGluZ3Mgd29ya2VkIGJlZm9y ZSB0aGUgY2hhbmdlIHRoYXQKPj4gaW50cm9kdWNlZCB0aGUgaXNzdWUgZ2V0dGluZyBmaXhlZCBo ZXJlPyBJIGhhZCBpbnRlbnRpb25hbGx5IGRlY2lkZWQKPj4gdG8gdXNlIEVSUk9SX0lOVkFMIGlu IHRoZSBwYXRjaCB2YXJpYW50IEkgZGlkIHN1Ym1pdCAoYXMgYXQgdGhhdAo+PiB0aW1lIEkgd2Fz bid0IHlldCBhd2FyZSBvZiB0aGUgb3RoZXIgZml4IGZsb2F0aW5nIGFyb3VuZCBhbHJlYWR5KS4K Pj4gCj4gCj4gV2hlbiBJIHdyb3RlIHRoaXMgcGF0Y2gsIEkgdGhvdWdodCB0aGUgcmV0dXJuIHZh bHVlIHNob3VsZCBiZSB0aWVkIHRvCj4geHNfdHJhbnNhY3Rpb25fZW5kLgoKeHNfdHJhbnNhY3Rp b25fZW5kKCkgcmV0dXJuaW5nIHplcm8gbWVhbnMgc3VjY2VzcyBhZmFpY3QuCgo+IFRoZSBvcmln aW5hbCBpbXBsZW1lbnRhdGlvbiBjb3VsZCByZXR1cm4gMSAtLSB0aGF0J3Mgbm90IEVSUk9SX0lO VkFMLAo+IHdoYXQgZGlkIEkgbWlzcz8gQW5kIHRoZSBvcmlnaW5hbCByZXR1cm4gdmFsdWUgd2Fz IG1hZCBlbm91Z2ggYW55d2F5IHNvCj4gSSBkb24ndCBzZWUgYSBuZWVkIHRvIHJldGFpbiB0aGF0 IC0tIGFmdGVyIGFsbCB0aGUgcHVycG9zZSBvZgo+IGVjZGM2ZmQ4Nzg3IGlzIHRvIGZpeCB0aGUg cmV0dXJuIHZhbHVlIG9mIHRoYXQgZnVuY3Rpb24uCgpJIGRpZG4ndCBtZWFuIHRvIHJldHVybiB0 byB0aGF0IGNydWRlIG1vZGVsLiBJdCBpcyBteSB1bmRlcnN0YW5kaW5nCnRoYXQgdGhlIG9yaWdp bmFsIG1lYW5pbmcgb2YgMSB3YXMgImludmFsaWQiIChhbmQgd291bGQgaGF2ZSByZXN1bHRlZAp3 aGVuIGdvaW5nIHRocm91Z2ggdGhlIHBhdGggaW4gcXVlc3Rpb24pLCBhbmQgaGVuY2UgRVJST1Jf SU5WQUwKd291bGQgYmUgdGhlIHByb3BlciByZXBsYWNlbWVudCBmb3IgdGhlIGNhc2Ugd2hlcmUg dGFyZ2V0IGFuZC9vcgpkb21pZCBhcmVuJ3QgdmFsaWQuCgpKYW4KCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=