From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] libxl: fix an error path that uses uninitialised rc in libxl_set_memory_target Date: Wed, 22 Jun 2016 09:20:57 -0600 Message-ID: <576AC8F902000078000F7BDB@prv-mh.provo.novell.com> References: <1465740590-21337-1-git-send-email-wei.liu2@citrix.com> <576AA79402000078000F7AC6@prv-mh.provo.novell.com> <20160622134704.GE1790@citrix.com> <576AB49402000078000F7B56@prv-mh.provo.novell.com> <20160622135934.GF1790@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjxd-0003cg-H8 for xen-devel@lists.xenproject.org; Wed, 22 Jun 2016 15:21:01 +0000 In-Reply-To: <20160622135934.GF1790@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: George Dunlap , Paulina Szubarczyk , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDIyLjA2LjE2IGF0IDE1OjU5LCA8d2VpLmxpdTJAY2l0cml4LmNvbT4gd3JvdGU6Cj4g T24gV2VkLCBKdW4gMjIsIDIwMTYgYXQgMDc6NTM6NTZBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4+ID4+PiBPbiAyMi4wNi4xNiBhdCAxNTo0NywgPHdlaS5saXUyQGNpdHJpeC5jb20+IHdy b3RlOgo+PiA+IE9uIFdlZCwgSnVuIDIyLCAyMDE2IGF0IDA2OjU4OjI4QU0gLTA2MDAsIEphbiBC ZXVsaWNoIHdyb3RlOgo+PiA+PiA+Pj4gT24gMTIuMDYuMTYgYXQgMTY6MDksIDx3ZWkubGl1MkBj aXRyaXguY29tPiB3cm90ZToKPj4gPj4gPiAtLS0gYS90b29scy9saWJ4bC9saWJ4bC5jCj4+ID4+ ID4gKysrIGIvdG9vbHMvbGlieGwvbGlieGwuYwo+PiA+PiA+IEBAIC00OTI3LDEwICs0OTI3LDEy IEBAIHJldHJ5X3RyYW5zYWN0aW9uOgo+PiA+PiA+ICAKPj4gPj4gPiAgICAgIHRhcmdldCA9IGxp YnhsX194c19yZWFkKGdjLCB0LCBHQ1NQUklOVEYoIiVzL21lbW9yeS90YXJnZXQiLCAKPiBkb21w YXRoKSk7Cj4+ID4+ID4gICAgICBpZiAoIXRhcmdldCAmJiAhZG9taWQpIHsKPj4gPj4gPiAtICAg ICAgICBpZiAoIXhzX3RyYW5zYWN0aW9uX2VuZChjdHgtPnhzaCwgdCwgMSkpCj4+ID4+ID4gKyAg ICAgICAgaWYgKCF4c190cmFuc2FjdGlvbl9lbmQoY3R4LT54c2gsIHQsIDEpKSB7Cj4+ID4+ID4g KyAgICAgICAgICAgIHJjID0gRVJST1JfRkFJTDsKPj4gPj4gCj4+ID4+IEknbSBzb3JyeSBmb3Ig bm90aWNpbmcgdGhpcyBvbmx5IG5vdyAtIGlzIEVSUk9SX0ZBSUwgdGhlIHJpZ2h0IHRoaW5nCj4+ ID4+IHRvIHVzZSBoZXJlLCBjb25zaWRlcmluZyBob3cgdGhpbmdzIHdvcmtlZCBiZWZvcmUgdGhl IGNoYW5nZSB0aGF0Cj4+ID4+IGludHJvZHVjZWQgdGhlIGlzc3VlIGdldHRpbmcgZml4ZWQgaGVy ZT8gSSBoYWQgaW50ZW50aW9uYWxseSBkZWNpZGVkCj4+ID4+IHRvIHVzZSBFUlJPUl9JTlZBTCBp biB0aGUgcGF0Y2ggdmFyaWFudCBJIGRpZCBzdWJtaXQgKGFzIGF0IHRoYXQKPj4gPj4gdGltZSBJ IHdhc24ndCB5ZXQgYXdhcmUgb2YgdGhlIG90aGVyIGZpeCBmbG9hdGluZyBhcm91bmQgYWxyZWFk eSkuCj4+ID4+IAo+PiA+IAo+PiA+IFdoZW4gSSB3cm90ZSB0aGlzIHBhdGNoLCBJIHRob3VnaHQg dGhlIHJldHVybiB2YWx1ZSBzaG91bGQgYmUgdGllZCB0bwo+PiA+IHhzX3RyYW5zYWN0aW9uX2Vu ZC4KPj4gCj4+IHhzX3RyYW5zYWN0aW9uX2VuZCgpIHJldHVybmluZyB6ZXJvIG1lYW5zIHN1Y2Nl c3MgYWZhaWN0Lgo+PiAKPiAKPiAvKiBFbmQgYSB0cmFuc2FjdGlvbi4KPiAgKiBJZiBhYmFuZG9u IGlzIHRydWUsIHRyYW5zYWN0aW9uIGlzIGRpc2NhcmRlZCBpbnN0ZWFkIG9mIGNvbW1pdHRlZC4K PiAgKiBSZXR1cm5zIGZhbHNlIG9uIGZhaWx1cmU6IGlmIGVycm5vID09IEVBR0FJTiwgeW91IGhh dmUgdG8gcmVzdGFydAo+ICAqIHRyYW5zYWN0aW9uLgo+ICAqLwo+IGJvb2wgeHNfdHJhbnNhY3Rp b25fZW5kKHN0cnVjdCB4c19oYW5kbGUgKmgsIHhzX3RyYW5zYWN0aW9uX3QgdCwKPiAgICAgICAg ICAgICAgICAgICAgICAgICBib29sIGFib3J0KTsKPiAKPiBJIHRoaW5rIHlvdSBtaXNyZWFkLgoK SW5kZWVkLCBJIGdvdCBtaXNsZWFkIGJ5ICJnb3RvIG91dF9ub190cmFuc2FjdGlvbiIuIFlldCB0 aGF0CmRvZXNuJ3QgY2hhbmdlIHRoZSBkaXNjdXNzaW9uIG9mIHRoZSBlcnJvciAtIG9yaWdpbmFs bHkgdGhpcyBkaWRuJ3QKcmV0dXJuIC0xIGhlcmUsIGJ1dCArMSAoaS5lLiByZWZsZWN0aW5nIHRo ZSBzdXJyb3VuZGluZyBpZigpLCBub3QKdGhlIGlubmVyIG9uZSkuCgpKYW4KCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBs aXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZl bAo=