From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>, Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v3 6/8] xen: Use the typesafe mfn and gfn in map_mmio_regions...
Date: Thu, 23 Jun 2016 15:08:32 +0100 [thread overview]
Message-ID: <576BED60.9030105@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1606231504320.2575@sstabellini-ThinkPad-X260>
On 23/06/16 15:05, Stefano Stabellini wrote:
>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>> index aa4e774..47cb383 100644
>> --- a/xen/arch/arm/p2m.c
>> +++ b/xen/arch/arm/p2m.c
>> @@ -1245,27 +1245,27 @@ int unmap_regions_rw_cache(struct domain *d,
>> }
>>
>> int map_mmio_regions(struct domain *d,
>> - unsigned long start_gfn,
>> + gfn_t start_gfn,
>> unsigned long nr,
>> - unsigned long mfn)
>> + mfn_t mfn)
>> {
>> return apply_p2m_changes(d, INSERT,
>> - pfn_to_paddr(start_gfn),
>> - pfn_to_paddr(start_gfn + nr),
>> - pfn_to_paddr(mfn),
>> + pfn_to_paddr(gfn_x(start_gfn)),
>> + pfn_to_paddr(gfn_x(start_gfn) + nr),
>> + pfn_to_paddr(mfn_x(mfn)),
>> MATTR_DEV, 0, p2m_mmio_direct,
>> d->arch.p2m.default_access);
>
> Any reason why you didn't push these changes down to apply_p2m_changes too?
To keep this series simple. I have another series coming up to push the
change down to apply_p2m_changes and clean up the P2M code.
I can move the patch to push down the change in this series if you prefer.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-23 14:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 13:20 [PATCH v3 0/8] xen/arm: Use the typesafes gfn and mfn Julien Grall
2016-06-21 13:20 ` [PATCH v3 1/8] xen/arm: Rename gmfn_to_mfn to gfn_to_mfn and use gfn/mfn typesafe Julien Grall
2016-06-23 10:06 ` Stefano Stabellini
2016-06-21 13:20 ` [PATCH v3 2/8] xen/mm: Introduce a bunch of helpers for the typesafes mfn and gfn Julien Grall
2016-06-22 7:03 ` Jan Beulich
2016-06-21 13:20 ` [PATCH v3 3/8] xen: Use typesafe gfn/mfn in guest_physmap_* helpers Julien Grall
2016-06-23 10:11 ` Stefano Stabellini
2016-06-21 13:20 ` [PATCH v3 4/8] xen: Use typesafe gfn in xenmem_add_to_physmap_one Julien Grall
2016-06-23 10:20 ` Stefano Stabellini
2016-06-23 10:43 ` Julien Grall
2016-06-23 13:06 ` Stefano Stabellini
2016-06-23 13:33 ` Julien Grall
2016-06-23 13:41 ` Stefano Stabellini
2016-06-23 13:58 ` Stefano Stabellini
2016-06-21 13:20 ` [PATCH v3 5/8] xen/arm: Rename grant_table_gfpn into grant_table_gfn and use the typesafe gfn Julien Grall
2016-06-23 14:00 ` Stefano Stabellini
2016-06-21 13:20 ` [PATCH v3 6/8] xen: Use the typesafe mfn and gfn in map_mmio_regions Julien Grall
2016-06-23 14:05 ` Stefano Stabellini
2016-06-23 14:08 ` Julien Grall [this message]
2016-06-23 14:15 ` Stefano Stabellini
2016-06-23 14:58 ` Julien Grall
2016-06-21 13:20 ` [PATCH v3 7/8] xen/arm: Rework the interface of p2m_lookup and use typesafe gfn and mfn Julien Grall
2016-06-23 14:14 ` Stefano Stabellini
2016-06-24 13:58 ` Julien Grall
2016-06-24 14:03 ` Andrew Cooper
2016-06-21 13:20 ` [PATCH v3 8/8] xen/arm: p2m_cache_flush: Use the correct terminology and typesafe gfn Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576BED60.9030105@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).