From: "Jan Beulich" <JBeulich@suse.com>
To: "kaih.linux@gmail.com" <kaih.linux@gmail.com>,
Kevin Tian <kevin.tian@intel.com>
Cc: Kai Huang <kai.huang@linux.intel.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen: x86: remove duplicated IA32_FEATURE_CONTROL MSR macro
Date: Fri, 24 Jun 2016 05:31:10 -0600 [thread overview]
Message-ID: <576D361E02000078000F885A@prv-mh.provo.novell.com> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D15F8D57D3@SHSMSX101.ccr.corp.intel.com>
>>> On 24.06.16 at 12:56, <kevin.tian@intel.com> wrote:
>> From: kaih.linux@gmail.com [mailto:kaih.linux@gmail.com]
>> Sent: Friday, June 24, 2016 6:45 PM
>> --- a/xen/include/asm-x86/msr-index.h
>> +++ b/xen/include/asm-x86/msr-index.h
>> @@ -133,12 +133,13 @@
>> #define MSR_IA32_VMX_TRUE_EXIT_CTLS 0x48f
>> #define MSR_IA32_VMX_TRUE_ENTRY_CTLS 0x490
>> #define MSR_IA32_VMX_VMFUNC 0x491
>> -#define IA32_FEATURE_CONTROL_MSR 0x3a
>> +#define MSR_IA32_FEATURE_CONTROL 0x3a
>
> Instead of moving MSR definition up here, better move all related lines
> down since original place is more sorted regarding to 0x3a.
I agree.
>> #define IA32_FEATURE_CONTROL_MSR_LOCK 0x0001
>> #define IA32_FEATURE_CONTROL_MSR_ENABLE_VMXON_INSIDE_SMX 0x0002
>> #define IA32_FEATURE_CONTROL_MSR_ENABLE_VMXON_OUTSIDE_SMX 0x0004
>> #define IA32_FEATURE_CONTROL_MSR_SENTER_PARAM_CTL 0x7f00
>> #define IA32_FEATURE_CONTROL_MSR_ENABLE_SENTER 0x8000
>> +#define IA32_FEATURE_CONTROL_MSR_SGX_ENABLE 0x40000
>
> suppose above macros better be changed in same style? Or is it
> really meaningful to keep whole MSR name in every bit definition?
> Is it clearly enough to just keep strings after _MSR_?
I partly agree. The _MSR_ infix is clearly pointless. I wouldn't,
however, like to see the IA32_FEATURE_CONTROL_ prefix
dropped, as it helps associating the bits with their MSR.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-24 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 10:45 [PATCH] xen: x86: remove duplicated IA32_FEATURE_CONTROL MSR macro kaih.linux
2016-06-24 10:56 ` Tian, Kevin
2016-06-24 11:31 ` Jan Beulich [this message]
2016-06-24 22:16 ` Huang, Kai
2016-06-28 2:27 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576D361E02000078000F885A@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=kai.huang@linux.intel.com \
--cc=kaih.linux@gmail.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).