From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 7/8] xen/arm: Rework the interface of p2m_lookup and use typesafe gfn and mfn Date: Fri, 24 Jun 2016 14:58:06 +0100 Message-ID: <576D3C6E.70800@arm.com> References: <1466515243-27264-1-git-send-email-julien.grall@arm.com> <1466515243-27264-8-git-send-email-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org SGkgU3RlZmFubywKCk9uIDIzLzA2LzE2IDE1OjE0LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6 Cj4gT24gVHVlLCAyMSBKdW4gMjAxNiwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+PiBUaGUgcHJvdG90 eXBlIGFuZCB0aGUgZGVjbGFyYXRpb24gb2YgcDJtX2xvb2t1cCBkaXNhZ3JlZSBvbiBob3cgdGhl Cj4+IGZ1bmN0aW9uIHNob3VsZCBiZSB1c2VkLiBPbmUgZXhwZWN0IGEgZnJhbWUgbnVtYmVyIHdo aWxzdCB0aGUgb3RoZXIKPj4gYW4gYWRkcmVzcy4KPj4KPj4gVGhhbmtmdWxseSwgZXZlcnlvbmUg aXMgdXNpbmcgd2l0aCBhbiBhZGRyZXNzIHRvZGF5LiBIb3dldmVyLCBtb3N0IG9mCj4+IHRoZSBj YWxsZXJzIGhhdmUgdG8gY29udmVydCBhIGd1ZXN0IGZyYW1lIHRvIGFuIGFkZHJlc3MuIE1vZGlm eQo+PiB0aGUgaW50ZXJmYWNlIHRvIHRha2UgYSBndWVzdCBwaHlzaWNhbCBmcmFtZSBpbiBwYXJh bWV0ZXIgYW5kIHJldHVybgo+PiBhIG1hY2hpbmUgZnJhbWUuCj4+Cj4+IFdoaWxzdCBtb2RpZnlp bmcgdGhlIGludGVyZmFjZSwgdXNlIHR5cGVzYWZlIGdmbiBhbmQgbWZuIGZvciBjbGFyaXR5Cj4+ IGFuZCBjYXRjaGluZyBwb3NzaWJsZSBtaXN1c2FnZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogSnVs aWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPj4gLS0tCj4+ICAgeGVuL2FyY2gvYXJt L3AybS5jICAgICAgICB8IDM3ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0K Pj4gICB4ZW4vYXJjaC9hcm0vdHJhcHMuYyAgICAgIHwgMjEgKysrKysrKysrKystLS0tLS0tLS0t Cj4+ICAgeGVuL2luY2x1ZGUvYXNtLWFybS9wMm0uaCB8ICA3ICsrKy0tLS0KPj4gICAzIGZpbGVz IGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0t Z2l0IGEveGVuL2FyY2gvYXJtL3AybS5jIGIveGVuL2FyY2gvYXJtL3AybS5jCj4+IGluZGV4IDQ3 Y2IzODMuLmYzMzMwZGQgMTAwNjQ0Cj4+IC0tLSBhL3hlbi9hcmNoL2FybS9wMm0uYwo+PiArKysg Yi94ZW4vYXJjaC9hcm0vcDJtLmMKPj4gQEAgLTE0MCwxNCArMTQwLDE1IEBAIHZvaWQgZmx1c2hf dGxiX2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkKQo+PiAgIH0KPj4KPj4gICAvKgo+PiAtICogTG9v a3VwIHRoZSBNRk4gY29ycmVzcG9uZGluZyB0byBhIGRvbWFpbidzIFBGTi4KPj4gKyAqIExvb2t1 cCB0aGUgTUZOIGNvcnJlc3BvbmRpbmcgdG8gYSBkb21haW4ncyBHRk4uCj4+ICAgICoKPj4gICAg KiBUaGVyZSBhcmUgbm8gcHJvY2Vzc29yIGZ1bmN0aW9ucyB0byBkbyBhIHN0YWdlIDIgb25seSBs b29rdXAgdGhlcmVmb3JlIHdlCj4+ICAgICogZG8gYSBhIHNvZnR3YXJlIHdhbGsuCj4+ICAgICov Cj4+IC1zdGF0aWMgcGFkZHJfdCBfX3AybV9sb29rdXAoc3RydWN0IGRvbWFpbiAqZCwgcGFkZHJf dCBwYWRkciwgcDJtX3R5cGVfdCAqdCkKPj4gK3N0YXRpYyBtZm5fdCBfX3AybV9sb29rdXAoc3Ry dWN0IGRvbWFpbiAqZCwgZ2ZuX3QgZ2ZuLCBwMm1fdHlwZV90ICp0KQo+PiAgIHsKPj4gICAgICAg c3RydWN0IHAybV9kb21haW4gKnAybSA9ICZkLT5hcmNoLnAybTsKPj4gKyAgICBjb25zdCBwYWRk cl90IHBhZGRyID0gcGZuX3RvX3BhZGRyKGdmbl94KGdmbikpOwo+PiAgICAgICBjb25zdCB1bnNp Z25lZCBpbnQgb2Zmc2V0c1s0XSA9IHsKPj4gICAgICAgICAgIHplcm9ldGhfdGFibGVfb2Zmc2V0 KHBhZGRyKSwKPj4gICAgICAgICAgIGZpcnN0X3RhYmxlX29mZnNldChwYWRkciksCj4+IEBAIC0x NTgsNyArMTU5LDcgQEAgc3RhdGljIHBhZGRyX3QgX19wMm1fbG9va3VwKHN0cnVjdCBkb21haW4g KmQsIHBhZGRyX3QgcGFkZHIsIHAybV90eXBlX3QgKnQpCj4+ICAgICAgICAgICBaRVJPRVRIX01B U0ssIEZJUlNUX01BU0ssIFNFQ09ORF9NQVNLLCBUSElSRF9NQVNLCj4+ICAgICAgIH07Cj4+ICAg ICAgIGxwYWVfdCBwdGUsICptYXA7Cj4+IC0gICAgcGFkZHJfdCBtYWRkciA9IElOVkFMSURfUEFE RFI7Cj4+ICsgICAgbWZuX3QgbWZuID0gX21mbihJTlZBTElEX01GTik7Cj4KPiBJdCBtaWdodCBi ZSB3b3J0aCBkZWZpbmluZyBJTlZBTElEX01GTl9UIGFuZCBqdXN0IGFzc2lnbiB0aGF0IHRvIG1m bi4KCkdvb2QgaWRlYS4gSXQgd2lsbCBiZSB1c2VmdWwgaW4gb3RoZXIgcGxhY2VzIHRvby4KCj4K Pj4gICAgICAgcGFkZHJfdCBtYXNrID0gMDsKPj4gICAgICAgcDJtX3R5cGVfdCBfdDsKPj4gICAg ICAgdW5zaWduZWQgaW50IGxldmVsLCByb290X3RhYmxlOwoKClsuLi5dCgo+PiBAQCAtMTU2MSwx MSArMTU2NSwxMCBAQCBwMm1fbWVtX2FjY2Vzc19jaGVja19hbmRfZ2V0X3BhZ2UodmFkZHJfdCBn dmEsIHVuc2lnbmVkIGxvbmcgZmxhZykKPj4gICAgICAgICogV2UgaGFkIGEgbWVtX2FjY2VzcyBw ZXJtaXNzaW9uIGxpbWl0aW5nIHRoZSBhY2Nlc3MsIGJ1dCB0aGUgcGFnZSB0eXBlCj4+ICAgICAg ICAqIGNvdWxkIGFsc28gYmUgbGltaXRpbmcsIHNvIHdlIG5lZWQgdG8gY2hlY2sgdGhhdCBhcyB3 ZWxsLgo+PiAgICAgICAgKi8KPj4gLSAgICBtYWRkciA9IF9fcDJtX2xvb2t1cChjdXJyZW50LT5k b21haW4sIGlwYSwgJnQpOwo+PiAtICAgIGlmICggbWFkZHIgPT0gSU5WQUxJRF9QQUREUiApCj4+ ICsgICAgbWZuID0gbWZuX3goX19wMm1fbG9va3VwKGN1cnJlbnQtPmRvbWFpbiwgZ2ZuLCAmdCkp Owo+PiArICAgIGlmICggbWZuID09IElOVkFMSURfTUZOICkKPgo+IFRoZSBjb252ZXJzaW9uIHdv dWxkIGdvIGF3YXkgaWYgd2UgaGFkIGFuIElOVkFMSURfTUZOIHdoaWNoIGlzIG1mbl90CgpXaWxs IGRvLgoKUmVnYXJkcywKCi0tIApKdWxpZW4gR3JhbGwKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==