Re: [PATCH V3 01/10] arm/gic-v3: Use acpi_table_parse_madt() to parse MADT subtables

From: Julien Grall <julien.grall@arm.com>
To: Shanker Donthineni <shankerd@codeaurora.org>,
	xen-devel <xen-devel@lists.xensource.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Cc: Philip Elcan <pelcan@codeaurora.org>,
	Vikram Sethi <vikrams@codeaurora.org>
Subject: Re: [PATCH V3 01/10] arm/gic-v3: Use acpi_table_parse_madt() to parse MADT subtables
Date: Tue, 28 Jun 2016 11:30:17 +0100	[thread overview]
Message-ID: <577251B9.4020608@arm.com> (raw)
In-Reply-To: <1467059622-14786-1-git-send-email-shankerd@codeaurora.org>

Hi Shanker,

On 27/06/16 21:33, Shanker Donthineni wrote:
> The function acpi_table_parse_madt() does the same functionality as
> function acpi_parse_entries() expect it takes a few arguments.
>
> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>

Reviewed-by: Julien Grall <julien.grall@arm.com>

Regards,

> ---
>   xen/arch/arm/gic-v3.c | 27 ++++++---------------------
>   1 file changed, 6 insertions(+), 21 deletions(-)
>
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 8d3f149..166f1c1 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -1390,28 +1390,15 @@ gic_acpi_get_madt_redistributor_num(struct acpi_subtable_header *header,
>
>   static void __init gicv3_acpi_init(void)
>   {
> -    struct acpi_table_header *table;
>       struct rdist_region *rdist_regs;
> -    acpi_status status;
>       int count, i;
>
> -    status = acpi_get_table(ACPI_SIG_MADT, 0, &table);
> -
> -    if ( ACPI_FAILURE(status) )
> -    {
> -        const char *msg = acpi_format_exception(status);
> -
> -        panic("GICv3: Failed to get MADT table, %s", msg);
> -    }
> -
>       /*
>        * Find distributor base address. We expect one distributor entry since
>        * ACPI 5.0 spec neither support multi-GIC instances nor GIC cascade.
>        */
> -    count = acpi_parse_entries(ACPI_SIG_MADT, sizeof(struct acpi_table_madt),
> -                               gic_acpi_parse_madt_distributor, table,
> -                               ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR, 0);
> -
> +    count = acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR,
> +                                  gic_acpi_parse_madt_distributor, 0);
>       if ( count <= 0 )
>           panic("GICv3: No valid GICD entries exists");
>
> @@ -1420,9 +1407,8 @@ static void __init gicv3_acpi_init(void)
>                 dbase);
>
>       /* Get number of redistributor */
> -    count = acpi_parse_entries(ACPI_SIG_MADT, sizeof(struct acpi_table_madt),
> -                               gic_acpi_get_madt_redistributor_num, table,
> -                               ACPI_MADT_TYPE_GENERIC_REDISTRIBUTOR, 0);
> +    count = acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_REDISTRIBUTOR,
> +                                  gic_acpi_get_madt_redistributor_num, 0);
>       if ( count <= 0 )
>           panic("GICv3: No valid GICR entries exists");
>
> @@ -1458,9 +1444,8 @@ static void __init gicv3_acpi_init(void)
>       gicv3.rdist_regions= rdist_regs;
>
>       /* Collect CPU base addresses */
> -    count = acpi_parse_entries(ACPI_SIG_MADT, sizeof(struct acpi_table_madt),
> -                               gic_acpi_parse_madt_cpu, table,
> -                               ACPI_MADT_TYPE_GENERIC_INTERRUPT, 0);
> +    count = acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_INTERRUPT,
> +                                  gic_acpi_parse_madt_cpu, 0);
>       if ( count <= 0 )
>           panic("GICv3: No valid GICC entries exists");
>
>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel