From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH V3 03/10] arm/gic-v3: Move GICR subtable parsing into a new function Date: Tue, 28 Jun 2016 11:36:07 +0100 Message-ID: <57725317.2050908@arm.com> References: <1467059622-14786-1-git-send-email-shankerd@codeaurora.org> <1467059622-14786-3-git-send-email-shankerd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1467059622-14786-3-git-send-email-shankerd@codeaurora.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Shanker Donthineni , xen-devel , Stefano Stabellini Cc: Philip Elcan , Vikram Sethi List-Id: xen-devel@lists.xenproject.org SGkgU2hhbmtlciwKCk9uIDI3LzA2LzE2IDIxOjMzLCBTaGFua2VyIERvbnRoaW5lbmkgd3JvdGU6 Cj4gQWRkIGEgbmV3IGZ1bmN0aW9uIHRvIHBhcnNlIEdJQ1Igc3VidGFibGUgYW5kIG1vdmUgdGhl IGNvZGUgdGhhdAo+IGlzIHNwZWNpZmljIHRvIEdJQ1IgdGFibGUgdG8gYSBuZXcgZnVuY3Rpb24g d2l0aG91dCBjaGFuZ2luZyB0aGUKPiBmdW5jdGlvbiBnaWN2M19hY3BpX2luaXQoKSBiZWhhdmlv ci4KPgo+IFNpZ25lZC1vZmYtYnk6IFNoYW5rZXIgRG9udGhpbmVuaSA8c2hhbmtlcmRAY29kZWF1 cm9yYS5vcmc+CgpBY2tlZC1ieTogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4K ClJlZ2FyZHMsCgo+IC0tLQo+IENoYW5nZXMgc2luY2UgdjI6Cj4gICAgQ2hhbmdlZCBmdW5jdGlv biBnaWNfYWNwaV9hZGRfcmRpc3RfcmVnaW9uKCkgcHJvdG95cGUuCj4gICAgUmVtb3ZlZCB0aGUg YWRkcmVzcyB2YWxpZGF0aW9uIGNoZWNrIGluIGdpY19hY3BpX3BhcnNlX21hZHRfcmVkaXN0cmli dXRvcigpLgo+ICAgIEVkaXRlZCBjb21taXQgdGV4dC4KPgo+IENoYW5nZXMgc2luY2UgdjE6Cj4g ICAgUmVtb3ZlZCB0aGUgdW5uZWNlc3NhcnkgR0lDUiBpb3JlbWFwIG9wZXJhdGlvbiBpbnNpZGUg R0lDUiB0YWJsZSBwYXJzZSBjb2RlLgo+Cj4KPiAgIHhlbi9hcmNoL2FybS9naWMtdjMuYyB8IDU2 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAg MSBmaWxlIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+Cj4gZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9naWMtdjMuYyBiL3hlbi9hcmNoL2FybS9naWMtdjMuYwo+ IGluZGV4IDFmOGZiYzQuLmVmZGI1NmIgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJtL2dpYy12 My5jCj4gKysrIGIveGVuL2FyY2gvYXJtL2dpYy12My5jCj4gQEAgLTEyODIsNiArMTI4MiwxNCBA QCBzdGF0aWMgaW50IGdpY3YzX2lvbWVtX2RlbnlfYWNjZXNzKGNvbnN0IHN0cnVjdCBkb21haW4g KmQpCj4gICB9Cj4KPiAgICNpZmRlZiBDT05GSUdfQUNQSQo+ICtzdGF0aWMgdm9pZCBfX2luaXQg Z2ljX2FjcGlfYWRkX3JkaXN0X3JlZ2lvbihwYWRkcl90IGJhc2UsIHBhZGRyX3Qgc2l6ZSkKPiAr ewo+ICsgICAgdW5zaWduZWQgaW50IGlkeCA9IGdpY3YzLnJkaXN0X2NvdW50Kys7Cj4gKwo+ICsg ICAgZ2ljdjMucmRpc3RfcmVnaW9uc1tpZHhdLmJhc2UgPSBiYXNlOwo+ICsgICAgZ2ljdjMucmRp c3RfcmVnaW9uc1tpZHhdLnNpemUgPSBzaXplOwo+ICt9Cj4gKwo+ICAgc3RhdGljIGludCBnaWN2 M19tYWtlX2h3ZG9tX21hZHQoY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwgdTMyIG9mZnNldCkKPiAg IHsKPiAgICAgICBzdHJ1Y3QgYWNwaV9zdWJ0YWJsZV9oZWFkZXIgKmhlYWRlcjsKPiBAQCAtMTM4 Nyw2ICsxMzk1LDIyIEBAIGdpY19hY3BpX3BhcnNlX21hZHRfZGlzdHJpYnV0b3Ioc3RydWN0IGFj cGlfc3VidGFibGVfaGVhZGVyICpoZWFkZXIsCj4KPiAgICAgICByZXR1cm4gMDsKPiAgIH0KPiAr Cj4gK3N0YXRpYyBpbnQgX19pbml0Cj4gK2dpY19hY3BpX3BhcnNlX21hZHRfcmVkaXN0cmlidXRv cihzdHJ1Y3QgYWNwaV9zdWJ0YWJsZV9oZWFkZXIgKmhlYWRlciwKPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNvbnN0IHVuc2lnbmVkIGxvbmcgZW5kKQo+ICt7Cj4gKyAgICBz dHJ1Y3QgYWNwaV9tYWR0X2dlbmVyaWNfcmVkaXN0cmlidXRvciAqcmRpc3Q7Cj4gKwo+ICsgICAg cmRpc3QgPSAoc3RydWN0IGFjcGlfbWFkdF9nZW5lcmljX3JlZGlzdHJpYnV0b3IgKiloZWFkZXI7 Cj4gKyAgICBpZiAoIEJBRF9NQURUX0VOVFJZKHJkaXN0LCBlbmQpICkKPiArICAgICAgICByZXR1 cm4gLUVJTlZBTDsKPiArCj4gKyAgICBnaWNfYWNwaV9hZGRfcmRpc3RfcmVnaW9uKHJkaXN0LT5i YXNlX2FkZHJlc3MsIHJkaXN0LT5sZW5ndGgpOwo+ICsKPiArICAgIHJldHVybiAwOwo+ICt9Cj4g Kwo+ICAgc3RhdGljIGludCBfX2luaXQKPiAgIGdpY19hY3BpX2dldF9tYWR0X3JlZGlzdHJpYnV0 b3JfbnVtKHN0cnVjdCBhY3BpX3N1YnRhYmxlX2hlYWRlciAqaGVhZGVyLAo+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgdW5zaWduZWQgbG9uZyBlbmQpCj4gQEAg LTE0MDAsNyArMTQyNCw3IEBAIGdpY19hY3BpX2dldF9tYWR0X3JlZGlzdHJpYnV0b3JfbnVtKHN0 cnVjdCBhY3BpX3N1YnRhYmxlX2hlYWRlciAqaGVhZGVyLAo+ICAgc3RhdGljIHZvaWQgX19pbml0 IGdpY3YzX2FjcGlfaW5pdCh2b2lkKQo+ICAgewo+ICAgICAgIHN0cnVjdCByZGlzdF9yZWdpb24g KnJkaXN0X3JlZ3M7Cj4gLSAgICBpbnQgY291bnQsIGk7Cj4gKyAgICBpbnQgY291bnQ7Cj4KPiAg ICAgICAvKgo+ICAgICAgICAqIEZpbmQgZGlzdHJpYnV0b3IgYmFzZSBhZGRyZXNzLiBXZSBleHBl Y3Qgb25lIGRpc3RyaWJ1dG9yIGVudHJ5IHNpbmNlCj4gQEAgLTE0MTksMzcgKzE0NDMsMjUgQEAg c3RhdGljIHZvaWQgX19pbml0IGdpY3YzX2FjcGlfaW5pdCh2b2lkKQo+ICAgICAgIGlmICggY291 bnQgPD0gMCApCj4gICAgICAgICAgIHBhbmljKCJHSUN2MzogTm8gdmFsaWQgR0lDUiBlbnRyaWVz IGV4aXN0cyIpOwo+Cj4gLSAgICBnaWN2My5yZGlzdF9jb3VudCA9IGNvdW50Owo+IC0KPiAtICAg IGlmICggZ2ljdjMucmRpc3RfY291bnQgPiBNQVhfUkRJU1RfQ09VTlQgKQo+ICsgICAgaWYgKCBj b3VudCA+IE1BWF9SRElTVF9DT1VOVCApCj4gICAgICAgICAgIHBhbmljKCJHSUN2MzogTnVtYmVy IG9mIHJlZGlzdHJpYnV0b3IgcmVnaW9ucyBpcyBtb3JlIHRoYW4iCj4gICAgICAgICAgICAgICAg ICIlZCAoSW5jcmVhc2UgTUFYX1JESVNUX0NPVU5UISEpXG4iLCBNQVhfUkRJU1RfQ09VTlQpOwo+ Cj4gLSAgICByZGlzdF9yZWdzID0geHphbGxvY19hcnJheShzdHJ1Y3QgcmRpc3RfcmVnaW9uLCBn aWN2My5yZGlzdF9jb3VudCk7Cj4gKyAgICByZGlzdF9yZWdzID0geHphbGxvY19hcnJheShzdHJ1 Y3QgcmRpc3RfcmVnaW9uLCBjb3VudCk7Cj4gICAgICAgaWYgKCAhcmRpc3RfcmVncyApCj4gICAg ICAgICAgIHBhbmljKCJHSUN2MzogRmFpbGVkIHRvIGFsbG9jYXRlIG1lbW9yeSBmb3IgcmRpc3Qg cmVnaW9uc1xuIik7Cj4KPiAtICAgIGZvciAoIGkgPSAwOyBpIDwgZ2ljdjMucmRpc3RfY291bnQ7 IGkrKyApCj4gLSAgICB7Cj4gLSAgICAgICAgc3RydWN0IGFjcGlfc3VidGFibGVfaGVhZGVyICpo ZWFkZXI7Cj4gLSAgICAgICAgc3RydWN0IGFjcGlfbWFkdF9nZW5lcmljX3JlZGlzdHJpYnV0b3Ig KmdpY19yZGlzdDsKPiAtCj4gLSAgICAgICAgaGVhZGVyID0gYWNwaV90YWJsZV9nZXRfZW50cnlf bWFkdChBQ1BJX01BRFRfVFlQRV9HRU5FUklDX1JFRElTVFJJQlVUT1IsCj4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpKTsKPiAtICAgICAgICBpZiAoICFoZWFk ZXIgKQo+IC0gICAgICAgICAgICBwYW5pYygiR0lDdjM6IENhbid0IGdldCBHSUNSIGVudHJ5Iik7 Cj4gLQo+IC0gICAgICAgIGdpY19yZGlzdCA9Cj4gLSAgICAgICAgICAgY29udGFpbmVyX29mKGhl YWRlciwgc3RydWN0IGFjcGlfbWFkdF9nZW5lcmljX3JlZGlzdHJpYnV0b3IsIGhlYWRlcik7Cj4g LSAgICAgICAgcmRpc3RfcmVnc1tpXS5iYXNlID0gZ2ljX3JkaXN0LT5iYXNlX2FkZHJlc3M7Cj4g LSAgICAgICAgcmRpc3RfcmVnc1tpXS5zaXplID0gZ2ljX3JkaXN0LT5sZW5ndGg7Cj4gLSAgICB9 Cj4gKyAgICBnaWN2My5yZGlzdF9yZWdpb25zID0gcmRpc3RfcmVnczsKPiArCj4gKyAgICAvKiBQ YXJzZSBhbHdheXMtb24gcG93ZXIgZG9tYWluIFJlLWRpc3RyaWJ1dG9yIGVudHJpZXMgKi8KPiAr ICAgIGNvdW50ID0gYWNwaV90YWJsZV9wYXJzZV9tYWR0KEFDUElfTUFEVF9UWVBFX0dFTkVSSUNf UkVESVNUUklCVVRPUiwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdpY19h Y3BpX3BhcnNlX21hZHRfcmVkaXN0cmlidXRvciwgY291bnQpOwo+ICsgICAgaWYgKCBjb3VudCA8 PSAwICkKPiArICAgICAgICBwYW5pYygiR0lDdjM6IENhbid0IGdldCBSZWRpc3RyaWJ1dG9yIGVu dHJ5Iik7Cj4KPiAgICAgICAvKiBUaGUgdkdJQyBjb2RlIHJlcXVpcmVzIHRoZSByZWdpb24gdG8g YmUgc29ydGVkICovCj4gICAgICAgc29ydChyZGlzdF9yZWdzLCBnaWN2My5yZGlzdF9jb3VudCwg c2l6ZW9mKCpyZGlzdF9yZWdzKSwgY21wX3JkaXN0LCBOVUxMKTsKPgo+IC0gICAgZ2ljdjMucmRp c3RfcmVnaW9ucz0gcmRpc3RfcmVnczsKPiAtCj4gICAgICAgLyogQ29sbGVjdCBDUFUgYmFzZSBh ZGRyZXNzZXMgKi8KPiAgICAgICBjb3VudCA9IGFjcGlfdGFibGVfcGFyc2VfbWFkdChBQ1BJX01B RFRfVFlQRV9HRU5FUklDX0lOVEVSUlVQVCwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBnaWNfYWNwaV9wYXJzZV9tYWR0X2NwdSwgMCk7Cj4KCi0tIApKdWxpZW4gR3JhbGwK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg==