From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH v5 17/17] xen/arm: p2m: Rework the interface of apply_p2m_changes and use typesafe
Date: Wed, 6 Jul 2016 12:56:33 +0100 [thread overview]
Message-ID: <577CF1F1.1070505@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1607061159580.26575@sstabellini-ThinkPad-X260>
Hi Stefano,
On 06/07/16 12:06, Stefano Stabellini wrote:
> On Tue, 28 Jun 2016, Julien Grall wrote:
>> @@ -1146,12 +1148,14 @@ out:
>> if ( rc < 0 && ( op == INSERT ) &&
>> addr != start_gpaddr )
>> {
>> + unsigned long gfn = paddr_to_pfn(addr);
>> +
>> BUG_ON(addr == end_gpaddr);
>> /*
>> * addr keeps the address of the end of the last successfully-inserted
>> * mapping.
>> */
>> - apply_p2m_changes(d, REMOVE, start_gpaddr, addr, orig_maddr,
>> + apply_p2m_changes(d, REMOVE, sgfn, gfn - gfn_x(sgfn), smfn,
>
> Worth considering a gfn_sub (we already have gfn_add)?
I thought about it. However the prototype of gfn_sub and gfn_add would
be different.
The former is subtracting two gfns whilst the latter is add a value to a
gfn. So I think it would be confusing for the user. Although, I am open
to any other suggestion.
Note that I am working on a series to rework the P2M code for supporting
Break-Before-Make. And a lot of this code will be different.
>
> In any case
>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
Thank you!
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-06 11:56 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 16:17 [PATCH v5 00/17] xen/arm: Use the typesafes gfn and mfn Julien Grall
2016-06-28 16:17 ` [PATCH v5 01/17] xen: Use typesafe gfn/mfn in guest_physmap_* helpers Julien Grall
2016-06-28 16:17 ` [PATCH v5 02/17] xen: Use typesafe gfn in xenmem_add_to_physmap_one Julien Grall
2016-06-28 16:17 ` [PATCH v5 03/17] xen/arm: Rename grant_table_gfpn into grant_table_gfn and use the typesafe gfn Julien Grall
2016-06-28 16:17 ` [PATCH v5 04/17] xen: Use the typesafe mfn and gfn in map_mmio_regions Julien Grall
2016-07-06 10:23 ` Stefano Stabellini
2016-06-28 16:17 ` [PATCH v5 05/17] xen/passthrough: x86: Use INVALID_GFN rather than INVALID_MFN Julien Grall
2016-06-28 16:43 ` Andrew Cooper
2016-06-28 16:47 ` Juergen Gross
2016-06-28 17:04 ` Julien Grall
2016-06-29 9:39 ` Jan Beulich
2016-06-28 16:17 ` [PATCH v5 06/17] xen: Use a typesafe to define INVALID_MFN Julien Grall
2016-06-28 17:05 ` Andrew Cooper
2016-07-06 10:27 ` Stefano Stabellini
2016-06-28 16:17 ` [PATCH v5 07/17] xen: Use a typesafe to define INVALID_GFN Julien Grall
2016-06-28 17:12 ` Andrew Cooper
2016-07-06 10:28 ` Stefano Stabellini
2016-06-28 16:17 ` [PATCH v5 08/17] xen/arm: Rework the interface of p2m_lookup and use typesafe gfn and mfn Julien Grall
2016-07-06 10:32 ` Stefano Stabellini
2016-06-28 16:17 ` [PATCH v5 09/17] xen/arm: Rework the interface of p2m_cache_flush and use typesafe gfn Julien Grall
2016-07-06 10:35 ` Stefano Stabellini
2016-06-28 16:17 ` [PATCH v5 10/17] xen/arm: map_regions_rw_cache: Map the region with p2m->default_access Julien Grall
2016-07-06 10:43 ` Stefano Stabellini
2016-07-06 11:10 ` Julien Grall
2016-07-06 11:17 ` Stefano Stabellini
2016-07-06 11:22 ` Julien Grall
2016-07-06 11:44 ` Julien Grall
2016-07-06 15:39 ` Tamas K Lengyel
2016-06-28 16:17 ` [PATCH v5 11/17] xen/arm: dom0_build: Remove dead code in allocate_memory Julien Grall
2016-07-06 10:46 ` Stefano Stabellini
2016-06-28 16:17 ` [PATCH v5 12/17] xen/arm: p2m: Remove unused operation ALLOCATE Julien Grall
2016-07-06 10:49 ` Stefano Stabellini
2016-06-28 16:17 ` [PATCH v5 13/17] xen/arm: Use the typesafes mfn and gfn in map_dev_mmio_region Julien Grall
2016-06-28 17:21 ` Andrew Cooper
2016-06-29 12:20 ` Julien Grall
2016-06-28 16:17 ` [PATCH v5 14/17] xen/arm: Use the typesafes mfn and gfn in map_regions_rw_cache Julien Grall
2016-07-06 10:54 ` Stefano Stabellini
2016-06-28 16:17 ` [PATCH v5 15/17] xen/arm: p2m: Introduce helpers to insert and remove mapping Julien Grall
2016-06-28 17:23 ` Andrew Cooper
2016-07-06 10:59 ` Stefano Stabellini
2016-07-06 11:20 ` Julien Grall
2016-06-28 16:17 ` [PATCH v5 16/17] xen/arm: p2m: Use typesafe gfn for {max, lowest}_mapped_gfn Julien Grall
2016-07-06 11:07 ` Stefano Stabellini
2016-06-28 16:17 ` [PATCH v5 17/17] xen/arm: p2m: Rework the interface of apply_p2m_changes and use typesafe Julien Grall
2016-07-06 11:06 ` Stefano Stabellini
2016-07-06 11:56 ` Julien Grall [this message]
2016-07-06 12:45 ` Andrew Cooper
2016-06-28 18:32 ` [PATCH v5 00/17] xen/arm: Use the typesafes gfn and mfn Andrew Cooper
2016-06-29 9:24 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577CF1F1.1070505@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).