xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: Juergen Gross <JGross@suse.com>,
	xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply()
Date: Fri, 8 Jul 2016 11:18:51 +0100	[thread overview]
Message-ID: <577F7E0B.6040404__49399.8850150549$1467973211$gmane$org@citrix.com> (raw)
In-Reply-To: <577E76BC02000078000FC3ED@prv-mh.provo.novell.com>

On 07/07/16 14:35, Jan Beulich wrote:
>>>> On 07.07.16 at 15:22, <david.vrabel@citrix.com> wrote:
>> On 07/07/16 14:13, David Vrabel wrote:
>>> On 07/07/16 13:23, Jan Beulich wrote:
>>>>>>> On 07.07.16 at 14:17, <david.vrabel@citrix.com> wrote:
>>>>> On 07/07/16 13:09, Jan Beulich wrote:
>>>>>>>>> On 07.07.16 at 13:36, <david.vrabel@citrix.com> wrote:
>>>>>>> On 07/07/16 08:32, Jan Beulich wrote:
>>>>>>>> We must not skip the transaction_end() call for a failed
>>>>>>>> XS_TRANSACTION_START. The removed code fragment got introduced by
>>>>>>>> commit 027bd7e899 ("xen/xenbus: Avoid synchronous wait on XenBus
>>>>>>>> stalling shutdown/restart") without its description really indicating
>>>>>>>> why it was added (and hence I can't identify whether a more complex
>>>>>>>> change might be needed here).
>>>>>>>
>>>>>>> If sending the XS_TRANSACTION_END message failed, then the transaction
>>>>>>> is still open and transaction_end() should not be called.
>>>>>>>
>>>>>>> However, if sending an XS_TRANSACTION_START failed, then
>>>>>>> transaction_end() should be called.
>>>>>>>
>>>>>>> So, yes a more complex fix is needed here.
>>>>>>
>>>>>> Well, both of the things you name are what happens with the patch
>>>>>> in place. So if those two conditions are all that needs to be satisfied,
>>>>>> then no more complex change is needed afaict (and was the behavior
>>>>>> before the cross referenced commit) - the question really is whether
>>>>>> that other commit meant to deal with something _beyond_ those two
>>>>>> things.
>>>>>
>>>>> You call transaction_end() if msg->type == XS_TRANSACTION_END, even if
>>>>> xb_write() returned an error.
>>>>
>>>> When xb_write() returns an error, msg->type gets set to XS_ERROR.
>>>
>>> So?
>>>
>>> 	if ((msg->type == XS_TRANSACTION_END) ||
>>> 	    (...))
>>> 		transaction_end();
>>>
>>> We don't check msg->type for XS_TRANSACTION_END messages.
>>
>> Sorry, being stupid.  Yeah, the change is fine but it needs a better
>> commit message.
> 
> I can certainly omit the part in parentheses. I don't think I should
> omit the reference to the original commit having introduced the issue.
> And without a more specific hint I also don't know what else may
> need changing. I'm sorry, I know I'm not doing very well in writing
> commit messages to your liking.

I rewrote it as:

xenbus: don't bail early from xenbus_dev_request_and_reply()

xenbus_dev_request_and_reply() needs to track whether a transaction is
open.  For XS_TRANSACTION_START messages it calls transaction_start()
and for XS_TRANSACTION_END messages it calls transaction_end().

If sending an XS_TRANSACTION_START message fails or responds with an
an error, the transaction is not open and transaction_end() must be
called.

If sending an XS_TRANSACTION_END message fails, the transaction is
still open, but if an error response is returned the transaction is
closed.

Commit 027bd7e89906 ("xen/xenbus: Avoid synchronous wait on XenBus
stalling shutdown/restart") introduced a regression where failed
XS_TRANSACTION_START messages were leaving the transaction open.  This
can cause problems with suspend (and migration) as all transaction must
be closed before suspending.

It appears that the problematic change was added accidentally, so just
remove it.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-07-08 10:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07  7:25 [PATCH 0/2] xenbus: xenbus_dev_request_and_reply() adjustments Jan Beulich
2016-07-07  7:32 ` [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() Jan Beulich
2016-07-07  7:32 ` [PATCH 2/2] xenbus: simplify xenbus_dev_request_and_reply() Jan Beulich
     [not found] ` <577E219402000078000FBDB6@prv-mh.provo.novell.com>
2016-07-07 11:36   ` [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply() David Vrabel
     [not found]   ` <577E3ED0.906@citrix.com>
2016-07-07 12:09     ` Jan Beulich
     [not found]     ` <577E629C02000078000FC32F@prv-mh.provo.novell.com>
2016-07-07 12:17       ` David Vrabel
     [not found]       ` <577E4865.1080307@citrix.com>
2016-07-07 12:23         ` Jan Beulich
     [not found]         ` <577E65CB02000078000FC35B@prv-mh.provo.novell.com>
2016-07-07 13:13           ` David Vrabel
     [not found]           ` <577E5565.40302@citrix.com>
2016-07-07 13:22             ` David Vrabel
     [not found]             ` <577E5793.5030209@citrix.com>
2016-07-07 13:35               ` Jan Beulich
2016-07-08 10:18                 ` David Vrabel [this message]
2016-07-08 10:56 ` [PATCH 0/2] xenbus: xenbus_dev_request_and_reply() adjustments David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='577F7E0B.6040404__49399.8850150549$1467973211$gmane$org@citrix.com' \
    --to=david.vrabel@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).