From: "Jan Beulich" <JBeulich@suse.com>
To: Corneliu ZUZU <czuzu@bitdefender.com>
Cc: Tamas K Lengyel <tamas@tklengyel.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xen.org, Paul Durrant <paul.durrant@citrix.com>
Subject: Re: [PATCH v3 3/8] x86/vm-event/monitor: don't compromise monitor_write_data on domain cleanup
Date: Fri, 08 Jul 2016 04:38:45 -0600 [thread overview]
Message-ID: <577F9ED502000078000FC8E4@prv-mh.provo.novell.com> (raw)
In-Reply-To: <4948695b-caca-d21a-f3f9-ee630840d848@bitdefender.com>
>>> On 08.07.16 at 12:28, <czuzu@bitdefender.com> wrote:
> On 7/8/2016 10:35 AM, Jan Beulich wrote:
>>>>> On 06.07.16 at 17:51, <czuzu@bitdefender.com> wrote:
>>> + /* write_data not fully handled, only xfree emul_read_data */
>> Comment style again (and more below).
>
> Ack, assuming you mean 'capital letter, end with dot'.
Actually in this particular case I meant only the missing full stop,
as the first word - afaict - refers to a structure field name (and
hence should remain lower case so e.g. a grep would catch it).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-08 10:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 15:49 [PATCH v3 0/8] x86/vm-event: Adjustments & fixes Corneliu ZUZU
2016-07-06 15:49 ` [PATCH v3 1/8] x86/vmx_update_guest_cr: minor optimization Corneliu ZUZU
2016-07-08 11:39 ` Corneliu ZUZU
2016-07-08 11:48 ` Jan Beulich
2016-07-08 11:55 ` Corneliu ZUZU
2016-07-08 12:11 ` Jan Beulich
2016-07-08 12:18 ` Ping: " Corneliu ZUZU
2016-07-11 2:37 ` Tian, Kevin
2016-07-06 15:50 ` [PATCH v3 2/8] x86/vm-event/monitor: relocate code-motion more appropriately Corneliu ZUZU
2016-07-08 7:21 ` Jan Beulich
2016-07-08 10:22 ` Corneliu ZUZU
2016-07-08 10:37 ` Jan Beulich
2016-07-08 11:33 ` Corneliu ZUZU
2016-07-08 11:53 ` Jan Beulich
2016-07-08 11:57 ` Corneliu ZUZU
2016-07-08 15:50 ` Tamas K Lengyel
2016-07-08 17:58 ` Corneliu ZUZU
2016-07-11 2:52 ` Tian, Kevin
2016-07-06 15:51 ` [PATCH v3 3/8] x86/vm-event/monitor: don't compromise monitor_write_data on domain cleanup Corneliu ZUZU
2016-07-08 7:35 ` Jan Beulich
2016-07-08 10:28 ` Corneliu ZUZU
2016-07-08 10:38 ` Jan Beulich [this message]
2016-07-06 15:52 ` [PATCH v3 4/8] x86/vm_event/monitor/cr: check for vm-event subscriber on domctl Corneliu ZUZU
2016-07-06 16:01 ` Jan Beulich
2016-07-06 16:15 ` Corneliu ZUZU
2016-07-06 16:20 ` Corneliu ZUZU
2016-07-07 7:30 ` Jan Beulich
2016-07-07 7:53 ` Corneliu ZUZU
2016-07-07 8:18 ` Corneliu ZUZU
2016-07-06 15:53 ` [PATCH v3 5/8] x86/vm_event_resume: surround VM_EVENT_REASON_MOV_TO_MSR w/ CONFIG_X86 Corneliu ZUZU
2016-07-06 15:54 ` [PATCH v3 6/8] x86/vm-event: minor ASSERT fix, add 'unlikely' Corneliu ZUZU
2016-07-07 8:27 ` Jan Beulich
2016-07-07 8:35 ` Corneliu ZUZU
2016-07-07 8:53 ` Jan Beulich
2016-07-07 23:24 ` Tamas K Lengyel
2016-07-06 15:55 ` [PATCH v3 7/8] minor fixes (formatting, comments, unused includes etc.) Corneliu ZUZU
2016-07-08 7:56 ` Jan Beulich
2016-07-08 10:37 ` Corneliu ZUZU
2016-07-06 15:55 ` [PATCH v3 8/8] minor #include change Corneliu ZUZU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577F9ED502000078000FC8E4@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=czuzu@bitdefender.com \
--cc=george.dunlap@eu.citrix.com \
--cc=paul.durrant@citrix.com \
--cc=rcojocaru@bitdefender.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).