xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather()
@ 2016-07-08 12:21 Jan Beulich
  0 siblings, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2016-07-08 12:21 UTC (permalink / raw)
  To: david.vrabel, boris.ostrovsky, Juergen Gross; +Cc: xen-devel, linux-kernel

For single items being collected this should be preferred as being more
typesafe (as the compiler can check format string and to-be-written-to
variable match) and more efficient (requiring one less parameter to be
passed).

1: xenbus: prefer xenbus_scanf() over xenbus_gather()
2: xen-blkback: prefer xenbus_scanf() over xenbus_gather()
3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
4: xen-netback: prefer xenbus_scanf() over xenbus_gather()

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Avoid commit messages to continue from subjects. Group into a series.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather()
       [not found]   ` <577FC9A0.9080407@citrix.com>
@ 2016-07-08 15:54     ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-08 15:54 UTC (permalink / raw)
  To: David Vrabel
  Cc: Juergen Gross, xen-devel, boris.ostrovsky, linux-kernel, Jan Beulich

On Fri, Jul 08, 2016 at 04:41:20PM +0100, David Vrabel wrote:
> On 08/07/16 15:17, Konrad Rzeszutek Wilk wrote:
> > On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote:
> >> For single items being collected this should be preferred as being more
> >> typesafe (as the compiler can check format string and to-be-written-to
> >> variable match) and more efficient (requiring one less parameter to be
> >> passed).
> >>
> >> 1: xenbus: prefer xenbus_scanf() over xenbus_gather()
> >> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather()
> >> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
> >> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather()
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> v2: Avoid commit messages to continue from subjects. Group into a series.
> > 
> > To confuse this, Roger and I are the block sub-maintainers, which
> > when we are happy, I send to Jens, while the rest go through Boris,David, and Juergen.
> > 
> > Anyhow, I've already committed and tested for regressions these:
> > 79ef83a xen-blkback: constify instance of "struct attribute_group"
> > 5e4d659 xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
> > e9d1ebe xen-blkback: prefer xenbus_scanf() over xenbus_gather()
> > 5b3b1db xen-blkback: really don't leak mode property
> 
> If they're tree wide largely mechanical changes to Xen-related APIs I
> prefer that they go via the Xen tree all together.
> 
> This saves the submitter chasing the individual subsystem maintainers.

Sure, but from a stricly SubmittingPatches point of view it would
fall on your to get the Acks from the other maintainers.

Either way, I am OK with those blkback and blkfront going through
your tree, albeit one will conflict with Jens 'for-4.8/drivers'.

> 
> David

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather()
  2016-07-08 14:17 ` Konrad Rzeszutek Wilk
  2016-07-08 15:06   ` Jan Beulich
       [not found]   ` <577FDD9C02000078000FCBEB@prv-mh.provo.novell.com>
@ 2016-07-08 15:41   ` David Vrabel
       [not found]   ` <577FC9A0.9080407@citrix.com>
  3 siblings, 0 replies; 6+ messages in thread
From: David Vrabel @ 2016-07-08 15:41 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk, Jan Beulich
  Cc: Juergen Gross, xen-devel, boris.ostrovsky, linux-kernel

On 08/07/16 15:17, Konrad Rzeszutek Wilk wrote:
> On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote:
>> For single items being collected this should be preferred as being more
>> typesafe (as the compiler can check format string and to-be-written-to
>> variable match) and more efficient (requiring one less parameter to be
>> passed).
>>
>> 1: xenbus: prefer xenbus_scanf() over xenbus_gather()
>> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather()
>> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
>> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather()
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v2: Avoid commit messages to continue from subjects. Group into a series.
> 
> To confuse this, Roger and I are the block sub-maintainers, which
> when we are happy, I send to Jens, while the rest go through Boris,David, and Juergen.
> 
> Anyhow, I've already committed and tested for regressions these:
> 79ef83a xen-blkback: constify instance of "struct attribute_group"
> 5e4d659 xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
> e9d1ebe xen-blkback: prefer xenbus_scanf() over xenbus_gather()
> 5b3b1db xen-blkback: really don't leak mode property

If they're tree wide largely mechanical changes to Xen-related APIs I
prefer that they go via the Xen tree all together.

This saves the submitter chasing the individual subsystem maintainers.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather()
       [not found]   ` <577FDD9C02000078000FCBEB@prv-mh.provo.novell.com>
@ 2016-07-08 15:12     ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-08 15:12 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Juergen Gross, xen-devel, boris.ostrovsky, david.vrabel, linux-kernel

On Fri, Jul 08, 2016 at 09:06:36AM -0600, Jan Beulich wrote:
> >>> On 08.07.16 at 16:17, <konrad.wilk@oracle.com> wrote:
> > On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote:
> >> For single items being collected this should be preferred as being more
> >> typesafe (as the compiler can check format string and to-be-written-to
> >> variable match) and more efficient (requiring one less parameter to be
> >> passed).
> >> 
> >> 1: xenbus: prefer xenbus_scanf() over xenbus_gather()
> >> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather()
> >> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
> >> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather()
> >> 
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> v2: Avoid commit messages to continue from subjects. Group into a series.
> > 
> > To confuse this, Roger and I are the block sub-maintainers, which
> > when we are happy, I send to Jens, while the rest go through Boris,David, 
> > and Juergen.
> 
> Which is why originally I had sent all of these separately. Yet David
> was pretty unhappy about that.

Aye!
I am not critizing, just saying that this is getting complicated and you
are in the unfortunate situation to have to deal with this - so want
to apoligize for you having to go through this gauntlet.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather()
  2016-07-08 14:17 ` Konrad Rzeszutek Wilk
@ 2016-07-08 15:06   ` Jan Beulich
       [not found]   ` <577FDD9C02000078000FCBEB@prv-mh.provo.novell.com>
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2016-07-08 15:06 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk
  Cc: Juergen Gross, xen-devel, boris.ostrovsky, david.vrabel, linux-kernel

>>> On 08.07.16 at 16:17, <konrad.wilk@oracle.com> wrote:
> On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote:
>> For single items being collected this should be preferred as being more
>> typesafe (as the compiler can check format string and to-be-written-to
>> variable match) and more efficient (requiring one less parameter to be
>> passed).
>> 
>> 1: xenbus: prefer xenbus_scanf() over xenbus_gather()
>> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather()
>> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
>> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather()
>> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v2: Avoid commit messages to continue from subjects. Group into a series.
> 
> To confuse this, Roger and I are the block sub-maintainers, which
> when we are happy, I send to Jens, while the rest go through Boris,David, 
> and Juergen.

Which is why originally I had sent all of these separately. Yet David
was pretty unhappy about that.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather()
       [not found] <577FB70002000078000FC9FA@prv-mh.provo.novell.com>
@ 2016-07-08 14:17 ` Konrad Rzeszutek Wilk
  2016-07-08 15:06   ` Jan Beulich
                     ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-08 14:17 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Juergen Gross, xen-devel, boris.ostrovsky, david.vrabel, linux-kernel

On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote:
> For single items being collected this should be preferred as being more
> typesafe (as the compiler can check format string and to-be-written-to
> variable match) and more efficient (requiring one less parameter to be
> passed).
> 
> 1: xenbus: prefer xenbus_scanf() over xenbus_gather()
> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather()
> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather()
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v2: Avoid commit messages to continue from subjects. Group into a series.

To confuse this, Roger and I are the block sub-maintainers, which
when we are happy, I send to Jens, while the rest go through Boris,David, and Juergen.

Anyhow, I've already committed and tested for regressions these:
79ef83a xen-blkback: constify instance of "struct attribute_group"
5e4d659 xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
e9d1ebe xen-blkback: prefer xenbus_scanf() over xenbus_gather()
5b3b1db xen-blkback: really don't leak mode property

And plan to send them to Jens. They will shortly be at my git tree
under 'stable/for-jens-4.8'.


> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-07-08 15:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-08 12:21 [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Jan Beulich
     [not found] <577FB70002000078000FC9FA@prv-mh.provo.novell.com>
2016-07-08 14:17 ` Konrad Rzeszutek Wilk
2016-07-08 15:06   ` Jan Beulich
     [not found]   ` <577FDD9C02000078000FCBEB@prv-mh.provo.novell.com>
2016-07-08 15:12     ` Konrad Rzeszutek Wilk
2016-07-08 15:41   ` David Vrabel
     [not found]   ` <577FC9A0.9080407@citrix.com>
2016-07-08 15:54     ` Konrad Rzeszutek Wilk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).