xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jan Beulich <JBeulich@suse.com>
Cc: Juergen Gross <JGross@suse.com>,
	xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
Subject: Re: [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather()
Date: Fri, 8 Jul 2016 16:41:20 +0100	[thread overview]
Message-ID: <577FC9A0.9080407__35626.7848321751$1467992624$gmane$org@citrix.com> (raw)
In-Reply-To: <20160708141737.GG22329@char.us.oracle.com>

On 08/07/16 15:17, Konrad Rzeszutek Wilk wrote:
> On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote:
>> For single items being collected this should be preferred as being more
>> typesafe (as the compiler can check format string and to-be-written-to
>> variable match) and more efficient (requiring one less parameter to be
>> passed).
>> 1: xenbus: prefer xenbus_scanf() over xenbus_gather()
>> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather()
>> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
>> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather()
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v2: Avoid commit messages to continue from subjects. Group into a series.
> To confuse this, Roger and I are the block sub-maintainers, which
> when we are happy, I send to Jens, while the rest go through Boris,David, and Juergen.
> Anyhow, I've already committed and tested for regressions these:
> 79ef83a xen-blkback: constify instance of "struct attribute_group"
> 5e4d659 xen-blkfront: prefer xenbus_scanf() over xenbus_gather()
> e9d1ebe xen-blkback: prefer xenbus_scanf() over xenbus_gather()
> 5b3b1db xen-blkback: really don't leak mode property

If they're tree wide largely mechanical changes to Xen-related APIs I
prefer that they go via the Xen tree all together.

This saves the submitter chasing the individual subsystem maintainers.


Xen-devel mailing list

  parent reply	other threads:[~2016-07-08 15:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <577FB70002000078000FC9FA@prv-mh.provo.novell.com>
2016-07-08 12:25 ` [PATCH v2 1/4] xenbus: prefer xenbus_scanf() over xenbus_gather() Jan Beulich
2016-07-08 12:26 ` [PATCH v2 2/4] xen-blkback: " Jan Beulich
2016-07-08 12:27 ` [PATCH v2 3/4] xen-blkfront: " Jan Beulich
2016-07-08 12:28 ` [PATCH v2 4/4] xen-netback: " Jan Beulich
2016-07-08 14:17 ` [PATCH v2 0/4] xen: " Konrad Rzeszutek Wilk
2016-07-08 15:06   ` Jan Beulich
     [not found]   ` <577FDD9C02000078000FCBEB@prv-mh.provo.novell.com>
2016-07-08 15:12     ` Konrad Rzeszutek Wilk
2016-07-08 15:41   ` David Vrabel [this message]
     [not found]   ` <577FC9A0.9080407@citrix.com>
2016-07-08 15:54     ` Konrad Rzeszutek Wilk
     [not found] ` <577FB8AA02000078000FCA21@prv-mh.provo.novell.com>
2016-07-08 16:14   ` [PATCH v2 4/4] xen-netback: " Wei Liu
2016-07-08 12:21 [PATCH v2 0/4] xen: " Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='577FC9A0.9080407__35626.7848321751$1467992624$gmane$org@citrix.com' \
    --to=david.vrabel@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).