From: Bin Wu <wu.wubin@huawei.com>
To: boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
jgross@suse.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, xen-devel@lists.xenproject.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
wu.wubin@huawei.com
Subject: [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed
Date: Mon, 11 Jul 2016 10:51:26 +0800 [thread overview]
Message-ID: <578309AE.1080704__39702.6213504889$1468209525$gmane$org@huawei.com> (raw)
During scsi command queueing, if mapping data fails, we need to
reclaim the failed request. Otherwise, the garbage request will
be pushed into the ring for the backend to work.
Signed-off-by: Bin Wu <wu.wubin@huawei.com>
---
drivers/scsi/xen-scsifront.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 9dc8687..655163d 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -565,6 +565,7 @@ static int scsifront_queuecommand(struct Scsi_Host *shost,
err = map_data_for_request(info, sc, ring_req, shadow);
if (err < 0) {
pr_debug("%s: err %d\n", __func__, err);
+ info->ring.req_prod_pvt--;
scsifront_put_rqid(info, rqid);
scsifront_return(info);
spin_unlock_irqrestore(shost->host_lock, flags);
--
2.3.2 (Apple Git-55)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2016-07-11 2:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 2:51 Bin Wu [this message]
[not found] <578309AE.1080704@huawei.com>
2016-07-11 9:33 ` [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed Juergen Gross
[not found] ` <578367E8.2050601@suse.com>
2016-07-11 9:50 ` David Vrabel
[not found] ` <57836BF4.9090000@citrix.com>
2016-07-11 9:53 ` Juergen Gross
2016-07-12 0:29 ` Bin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='578309AE.1080704__39702.6213504889$1468209525$gmane$org@huawei.com' \
--to=wu.wubin@huawei.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).