From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [PATCH 01/19] xen: Create a new file xen_pvdev.c Date: Mon, 18 Jul 2016 08:57:38 -0600 Message-ID: <578CEE62.7010700@redhat.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5684380396495596001==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Quan Xu , rea , Stefano Stabellini , "anthony.perard" Cc: dgdegra , xen-devel , "wei.liu2" , qemu-devel , stefanb List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5684380396495596001== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NH2UVepvHT1U72KQh7Eb6x2rdeFM7BnnS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NH2UVepvHT1U72KQh7Eb6x2rdeFM7BnnS Content-Type: multipart/mixed; boundary="Oi7g6CKMqG5B9m5GlTj0tJr10C5nQgd9Q" From: Eric Blake To: Quan Xu , rea , Stefano Stabellini , "anthony.perard" Cc: qemu-devel , stefanb , xen-devel , dgdegra , "wei.liu2" Message-ID: <578CEE62.7010700@redhat.com> Subject: Re: [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c References: In-Reply-To: --Oi7g6CKMqG5B9m5GlTj0tJr10C5nQgd9Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/17/2016 01:41 AM, Quan Xu wrote: >=20 > [Quan:]: comment starts with [Quan:] >=20 This line doesn't belong in a commit message; it's fine to put it after the --- separator though, if it aids mailing list reviewers. >=20 > The purpose of the new file is to store generic functions shared by fro= ntendand backends such as xenstore operations, xendevs. >=20 s/frontendand/front end and/ Please wrap your commit message lines. Since 'git log' displays logs with indentation, wrapping around 72 characters is ideal. > Signed-off-by: Quan Xu > Signed-off-by: Emil Condrea These are not valid S-o-b, therefore this patch cannot be applied as-is. > -int xenstore_read_int(const char *base, const char *node, int *ival) > -{ > - char *val; > - int rc =3D -1; > - > - val =3D xenstore_read_str(base, node); > [Quan:]: IMO, it is better to initialize val when declares. the same = comment for the other 'val' > - if (val && 1 =3D=3D sscanf(val, "%d", ival)) { This is not a valid patch. Are you replying to a patch that someone else posted? If so, your quoting style is VERY difficult to read. Please consider using a leading > before every line that you are quoting (rather than pasting it verbatim as if you had written it), and include a blank line both before and after every line that you insert, to call visual attention to what is your reply vs. what you are quoting. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Oi7g6CKMqG5B9m5GlTj0tJr10C5nQgd9Q-- --NH2UVepvHT1U72KQh7Eb6x2rdeFM7BnnS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXjO5jAAoJEKeha0olJ0NqhYsH/2z6L40TRIXCiRTjZmlSFVQO amMzzFgaSkyJrj8HabzBYVSWUvyukhKJoBPslh/Gsjx+SkOlc0EXIKgKGVB6BDeK oMXJZse1uYVYcLkhP1hgPR4NLXSubjaCs4lhvBTN/gWmAxx0h7T63R6s9F3scsYT wNL6XZSjMhiZnm585ce0Z9ZBnkZVkvS5M87ndp5Xzf7s1jeH9YHNAnGHniMrCs3A epMEXczXfDInN9cgbZPZPnqpTWvfHi8PsJfTZyuIuDK7UW+g9PJMEzhJa8zgFhgr YwsajqqzlivG7KnR1vMI/i7AI/8ZpyjKvOmkozf57+nOMOQHOC2ViTQrMvsGNTc= =gNXe -----END PGP SIGNATURE----- --NH2UVepvHT1U72KQh7Eb6x2rdeFM7BnnS-- --===============5684380396495596001== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5684380396495596001==--