From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 5/9] x86/hypercall: Move the hypercall tables into C
Date: Tue, 02 Aug 2016 07:23:32 -0600 [thread overview]
Message-ID: <57A0BAF40200007800101CC4@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1468835505-7278-6-git-send-email-andrew.cooper3@citrix.com>
>>> On 18.07.16 at 11:51, <andrew.cooper3@citrix.com> wrote:
> +hypercall_fn_t *const hypercall_table[NR_hypercalls] = {
> + HYPERCALL(set_trap_table),
> + HYPERCALL(mmu_update),
> + HYPERCALL(set_gdt),
> + HYPERCALL(stack_switch),
> + HYPERCALL(set_callbacks),
> + HYPERCALL(fpu_taskswitch),
> + HYPERCALL(sched_op_compat),
> + HYPERCALL(platform_op),
> + HYPERCALL(set_debugreg),
> + HYPERCALL(get_debugreg),
> + HYPERCALL(update_descriptor),
> + HYPERCALL(memory_op),
> + HYPERCALL(multicall),
> + HYPERCALL(update_va_mapping),
> + HYPERCALL(set_timer_op),
> + HYPERCALL(event_channel_op_compat),
> + HYPERCALL(xen_version),
> + HYPERCALL(console_io),
> + HYPERCALL(physdev_op_compat),
> + HYPERCALL(grant_table_op),
> + HYPERCALL(vm_assist),
> + HYPERCALL(update_va_mapping_otherdomain),
> + HYPERCALL(iret),
> + HYPERCALL(vcpu_op),
> + HYPERCALL(set_segment_base),
> + HYPERCALL(mmuext_op),
> + HYPERCALL(xsm_op),
> + HYPERCALL(nmi_op),
> + HYPERCALL(sched_op),
> + HYPERCALL(callback_op),
> +#ifdef CONFIG_XENOPROF
> + HYPERCALL(xenoprof_op),
> +#endif
> + HYPERCALL(event_channel_op),
> + HYPERCALL(physdev_op),
> + HYPERCALL(hvm_op),
> + HYPERCALL(sysctl),
> + HYPERCALL(domctl),
> +#ifdef CONFIG_KEXEC
> + HYPERCALL(kexec_op),
> +#endif
> +#ifdef CONFIG_TMEM
> + HYPERCALL(tmem_op),
> +#endif
To be honest I'd prefer the necessary #ifdef-ery to live in hypercall.h,
the more that then ARM could (if they want) benefit from that too.
> +hypercall_fn_t *const compat_hypercall_table[NR_hypercalls] = {
Is it really helpful to create two separate tables here, just to then
merge them in patch 7?
> --- a/xen/arch/x86/x86_64/entry.S
> +++ b/xen/arch/x86/x86_64/entry.S
> @@ -682,68 +682,6 @@ ENTRY(exception_table)
> .endr
> .size exception_table, . - exception_table
>
> -#ifndef CONFIG_KEXEC
>[...]
> - .endr
>
> /* Table of automatically generated entry points. One per vector. */
Please don't leave behind two blank lines.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-02 13:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 9:51 [PATCH 0/9] x86: Move the pv hypercall into C Andrew Cooper
2016-07-18 9:51 ` [PATCH 1/9] x86/hypercall: Move some of the hvm hypercall infrastructure into hypercall.h Andrew Cooper
2016-08-02 12:50 ` Jan Beulich
2016-08-02 13:14 ` Andrew Cooper
2016-08-02 13:28 ` Jan Beulich
2016-08-02 14:04 ` Julien Grall
2016-08-02 14:17 ` Jan Beulich
2016-08-02 14:26 ` Julien Grall
2016-08-02 14:54 ` Jan Beulich
2016-08-02 14:59 ` Andrew Cooper
2016-08-02 15:05 ` Jan Beulich
2016-08-02 18:43 ` Stefano Stabellini
2016-08-03 8:53 ` Jan Beulich
2016-08-03 10:55 ` Julien Grall
2016-08-03 18:20 ` Stefano Stabellini
2016-08-04 11:27 ` Julien Grall
2016-07-18 9:51 ` [PATCH 2/9] x86/pv: Support do_set_segment_base() for compat guests Andrew Cooper
2016-08-02 12:52 ` Jan Beulich
2016-08-02 13:25 ` Andrew Cooper
2016-08-02 13:31 ` Jan Beulich
2016-08-02 13:39 ` Andrew Cooper
2016-08-02 13:47 ` Jan Beulich
2016-07-18 9:51 ` [PATCH 3/9] x86/hypercall: Move the hypercall arg tables into C Andrew Cooper
2016-08-02 12:59 ` Jan Beulich
2016-07-18 9:51 ` [PATCH 4/9] x86/pv: Implement pv_hypercall() in C Andrew Cooper
2016-08-02 13:12 ` Jan Beulich
2016-08-02 14:06 ` Andrew Cooper
2016-08-02 14:19 ` Jan Beulich
2016-08-11 11:57 ` Andrew Cooper
2016-08-11 12:20 ` Jan Beulich
2016-07-18 9:51 ` [PATCH 5/9] x86/hypercall: Move the hypercall tables into C Andrew Cooper
2016-08-02 13:23 ` Jan Beulich [this message]
2016-08-02 13:30 ` Andrew Cooper
2016-08-02 13:40 ` Jan Beulich
2016-08-11 12:00 ` Andrew Cooper
2016-07-18 9:51 ` [PATCH 6/9] xen/multicall: Rework arch multicall handling Andrew Cooper
2016-07-20 12:35 ` Julien Grall
2016-08-03 15:02 ` Jan Beulich
2016-08-03 15:12 ` Andrew Cooper
2016-07-18 9:51 ` [PATCH 7/9] x86/pv: Merge the pv hypercall tables Andrew Cooper
2016-08-03 15:07 ` Jan Beulich
2016-08-11 12:36 ` Andrew Cooper
2016-07-18 9:51 ` [PATCH 8/9] x86/hypercall: Merge the hypercall arg tables Andrew Cooper
2016-08-03 15:12 ` Jan Beulich
2016-08-03 15:15 ` Andrew Cooper
2016-08-03 15:28 ` Jan Beulich
2016-07-18 9:51 ` [PATCH 9/9] x86/hypercall: Reduce the size of the hypercall tables Andrew Cooper
2016-08-03 15:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A0BAF40200007800101CC4@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).