From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F971C432C2 for ; Thu, 26 Sep 2019 08:04:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A6DA21A4A for ; Thu, 26 Sep 2019 08:04:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A6DA21A4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDOkz-0001va-0l; Thu, 26 Sep 2019 08:04:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDOkx-0001vV-B5 for xen-devel@lists.xenproject.org; Thu, 26 Sep 2019 08:04:07 +0000 X-Inumbo-ID: 35c023d2-e034-11e9-9649-12813bfff9fa Received: from mx1.suse.de (unknown [195.135.220.15]) by localhost (Halon) with ESMTPS id 35c023d2-e034-11e9-9649-12813bfff9fa; Thu, 26 Sep 2019 08:04:06 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 34712AD14; Thu, 26 Sep 2019 08:04:05 +0000 (UTC) To: Andrew Cooper References: <20190913192759.10795-9-andrew.cooper3@citrix.com> <20190925181100.26580-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <57f457fb-b7fa-6d7d-b877-eee11b3b6fe6@suse.com> Date: Thu, 26 Sep 2019 10:04:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190925181100.26580-1-andrew.cooper3@citrix.com> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH v3 08/10] tools/libxc: Rework xc_cpuid_apply_policy() to use {get, set}_cpu_policy() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMjUuMDkuMjAxOSAyMDoxMSwgQW5kcmV3IENvb3BlciB3cm90ZToKPiAraW50IHhjX2NwdWlk X2FwcGx5X3BvbGljeSh4Y19pbnRlcmZhY2UgKnhjaCwgdWludDMyX3QgZG9taWQsCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgY29uc3QgdWludDMyX3QgKmZlYXR1cmVzZXQsIHVuc2lnbmVk IGludCBucl9mZWF0dXJlcykKPiArewo+ICsgICAgaW50IHJjOwo+ICsgICAgeGNfZG9taW5mb190 IGRpOwo+ICsgICAgdW5zaWduZWQgaW50IGksIG5yX2xlYXZlcywgbnJfbXNyczsKPiArICAgIHhl bl9jcHVpZF9sZWFmX3QgKmxlYXZlcyA9IE5VTEw7Cj4gKyAgICBzdHJ1Y3QgY3B1aWRfcG9saWN5 ICpwID0gTlVMTDsKPiArICAgIHVpbnQzMl90IGVycl9sZWFmID0gLTEsIGVycl9zdWJsZWFmID0g LTEsIGVycl9tc3IgPSAtMTsKPiArCj4gKyAgICBpZiAoIHhjX2RvbWFpbl9nZXRpbmZvKHhjaCwg ZG9taWQsIDEsICZkaSkgIT0gMSB8fAo+ICsgICAgICAgICBkaS5kb21pZCAhPSBkb21pZCApCj4g KyAgICB7Cj4gKyAgICAgICAgRVJST1IoIkZhaWxlZCB0byBvYnRhaW4gZCVkIGluZm8iLCBkb21p ZCk7Cj4gKyAgICAgICAgcmMgPSAtRVNSQ0g7Cj4gKyAgICAgICAgZ290byBvdXQ7Cj4gKyAgICB9 Cj4gKwo+ICsgICAgcmMgPSB4Y19nZXRfY3B1X3BvbGljeV9zaXplKHhjaCwgJm5yX2xlYXZlcywg Jm5yX21zcnMpOwo+ICsgICAgaWYgKCByYyApCj4gKyAgICB7Cj4gKyAgICAgICAgUEVSUk9SKCJG YWlsZWQgdG8gb2J0YWluIHBvbGljeSBpbmZvIHNpemUiKTsKPiArICAgICAgICByYyA9IC1lcnJu bzsKPiArICAgICAgICBnb3RvIG91dDsKPiArICAgIH0KPiArCj4gKyAgICByYyA9IC1FTk9NRU07 Cj4gKyAgICBpZiAoIChsZWF2ZXMgPSBjYWxsb2MobnJfbGVhdmVzLCBzaXplb2YoKmxlYXZlcykp KSA9PSBOVUxMIHx8Cj4gKyAgICAgICAgIChwID0gY2FsbG9jKDEsIHNpemVvZigqcCkpKSA9PSBO VUxMICkKPiArICAgICAgICBnb3RvIG91dDsKPiArCj4gKyAgICAvKiBHZXQgdGhlIGRvbWFpbidz IGRlZmF1bHQgcG9saWN5LiAqLwo+ICsgICAgbnJfbXNycyA9IDA7Cj4gKyAgICByYyA9IHhjX2dl dF9zeXN0ZW1fY3B1X3BvbGljeSh4Y2gsIGRpLmh2bSA/IFhFTl9TWVNDVExfY3B1X3BvbGljeV9o dm1fZGVmYXVsdAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgOiBYRU5fU1lTQ1RMX2NwdV9wb2xpY3lfcHZfZGVmYXVsdCwKPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICZucl9sZWF2ZXMsIGxlYXZlcywgJm5yX21zcnMsIE5VTEwpOwo+ ICsgICAgaWYgKCByYyApCj4gKyAgICB7Cj4gKyAgICAgICAgUEVSUk9SKCJGYWlsZWQgdG8gb2J0 YWluICVzIGRlZmF1bHQgcG9saWN5IiwgZGkuaHZtID8gImh2bSIgOiAicHYiKTsKPiArICAgICAg ICByYyA9IC1lcnJubzsKPiArICAgICAgICBnb3RvIG91dDsKPiArICAgIH0KPiArCj4gKyAgICBy YyA9IHg4Nl9jcHVpZF9jb3B5X2Zyb21fYnVmZmVyKHAsIGxlYXZlcywgbnJfbGVhdmVzLAo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZXJyX2xlYWYsICZlcnJfc3VibGVh Zik7Cj4gKyAgICBpZiAoIHJjICkKPiArICAgIHsKPiArICAgICAgICBFUlJPUigiRmFpbGVkIHRv IGRlc2VyaWFsaXNlIENQVUlEIChlcnIgbGVhZiAlI3gsIHN1YmxlYWYgJSN4KSAoJWQgPSAlcyki LAo+ICsgICAgICAgICAgICAgIGVycl9sZWFmLCBlcnJfc3VibGVhZiwgLXJjLCBzdHJlcnJvcigt cmMpKTsKPiArICAgICAgICBnb3RvIG91dDsKPiArICAgIH0KPiArCj4gKyAgICBpZiAoIGZlYXR1 cmVzZXQgKQo+ICsgICAgewo+ICsgICAgICAgIHVpbnQzMl90IGRpc2FibGVkX2ZlYXR1cmVzW0ZF QVRVUkVTRVRfTlJfRU5UUklFU10sCj4gKyAgICAgICAgICAgIGZlYXRbRkVBVFVSRVNFVF9OUl9F TlRSSUVTXSA9IHt9Owo+ICsgICAgICAgIHN0YXRpYyBjb25zdCB1aW50MzJfdCBkZWVwX2ZlYXR1 cmVzW10gPSBJTklUX0RFRVBfRkVBVFVSRVM7Cj4gKyAgICAgICAgdW5zaWduZWQgaW50IGksIGI7 Cj4gKwo+ICsgICAgICAgIC8qCj4gKyAgICAgICAgICogVGhlIHVzZXIgc3VwcGxpZWQgZmVhdHVy ZXNldCBtYXkgYmUgc2hvcnRlciBvciBsb25nZXIgdGhhbgo+ICsgICAgICAgICAqIEZFQVRVUkVT RVRfTlJfRU5UUklFUy4gIFNob3J0ZXIgaXMgZmluZSwgYW5kIHdlIHdpbGwgemVyby1leHRlbmQu Cj4gKyAgICAgICAgICogTG9uZ2VyIGlzIGZpbmUsIHNvIGxvbmcgYXMgaXQgb25seSBwYWRkZWQg d2l0aCB6ZXJvcy4KPiArICAgICAgICAgKi8KPiArICAgICAgICB1bnNpZ25lZCBpbnQgdXNlcl9s ZW4gPSBtaW4oRkVBVFVSRVNFVF9OUl9FTlRSSUVTICsgMHUsIG5yX2ZlYXR1cmVzKTsKPiArCj4g KyAgICAgICAgLyogQ2hlY2sgZm9yIHRydW5jYXRlZCBzZXQgYml0cy4gKi8KPiArICAgICAgICBy YyA9IC1FT1BOT1RTVVBQOwo+ICsgICAgICAgIGZvciAoIGkgPSB1c2VyX2xlbjsgaSA8IG5yX2Zl YXR1cmVzOyArK2kgKQo+ICsgICAgICAgICAgICBpZiAoIGZlYXR1cmVzZXRbaV0gIT0gMCApCj4g KyAgICAgICAgICAgICAgICBnb3RvIG91dDsKPiArCj4gKyAgICAgICAgbWVtY3B5KGZlYXQsIGZl YXR1cmVzZXQsIHNpemVvZigqZmVhdHVyZXNldCkgKiB1c2VyX2xlbik7Cj4gKwo+ICsgICAgICAg IC8qIERpc2FibGUgZGVlcCBkZXBlbmRlbmNpZXMgb2YgZGlzYWJsZWQgZmVhdHVyZXMuICovCj4g KyAgICAgICAgZm9yICggaSA9IDA7IGkgPCBBUlJBWV9TSVpFKGRpc2FibGVkX2ZlYXR1cmVzKTsg KytpICkKPiArICAgICAgICAgICAgZGlzYWJsZWRfZmVhdHVyZXNbaV0gPSB+ZmVhdFtpXSAmIGRl ZXBfZmVhdHVyZXNbaV07Cj4gKwo+ICsgICAgICAgIGZvciAoIGIgPSAwOyBiIDwgc2l6ZW9mKGRp c2FibGVkX2ZlYXR1cmVzKSAqIENIQVJfQklUOyArK2IgKQo+ICsgICAgICAgIHsKPiArICAgICAg ICAgICAgY29uc3QgdWludDMyX3QgKmRmczsKPiArCj4gKyAgICAgICAgICAgIGlmICggIXRlc3Rf Yml0KGIsIGRpc2FibGVkX2ZlYXR1cmVzKSB8fAo+ICsgICAgICAgICAgICAgICAgICEoZGZzID0g eDg2X2NwdWlkX2xvb2t1cF9kZWVwX2RlcHMoYikpICkKPiArICAgICAgICAgICAgICAgIGNvbnRp bnVlOwo+ICsKPiArICAgICAgICAgICAgZm9yICggaSA9IDA7IGkgPCBBUlJBWV9TSVpFKGRpc2Fi bGVkX2ZlYXR1cmVzKTsgKytpICkKPiArICAgICAgICAgICAgewo+ICsgICAgICAgICAgICAgICAg ZmVhdFtpXSAmPSB+ZGZzW2ldOwo+ICsgICAgICAgICAgICAgICAgZGlzYWJsZWRfZmVhdHVyZXNb aV0gJj0gfmRmc1tpXTsKPiArICAgICAgICAgICAgfQo+ICsgICAgICAgIH0KPiArCj4gKyAgICAg ICAgY3B1aWRfZmVhdHVyZXNldF90b19wb2xpY3koZmVhdCwgcCk7Cj4gKyAgICB9Cj4gKwo+ICsg ICAgaWYgKCAhZGkuaHZtICkKPiArICAgIHsKPiArICAgICAgICB1aW50MzJfdCBob3N0X2ZlYXR1 cmVzZXRbRkVBVFVSRVNFVF9OUl9FTlRSSUVTXSA9IHt9Owo+ICsgICAgICAgIHVpbnQzMl90IGxl biA9IEFSUkFZX1NJWkUoaG9zdF9mZWF0dXJlc2V0KTsKPiArCj4gKyAgICAgICAgcmMgPSB4Y19n ZXRfY3B1X2ZlYXR1cmVzZXQoeGNoLCBYRU5fU1lTQ1RMX2NwdV9mZWF0dXJlc2V0X2hvc3QsCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmxlbiwgaG9zdF9mZWF0dXJlc2V0 KTsKPiArICAgICAgICBpZiAoIHJjICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIC8qIFRv bGVyYXRlICJidWZmZXIgdG9vIHNtYWxsIiwgYXMgd2UndmUgZ290IHRoZSBiaXRzIHdlIG5lZWQu ICovCj4gKyAgICAgICAgICAgIGlmICggZXJybm8gPT0gRU5PQlVGUyApCj4gKyAgICAgICAgICAg ICAgICByYyA9IDA7Cj4gKyAgICAgICAgICAgIGVsc2UKPiArICAgICAgICAgICAgewo+ICsgICAg ICAgICAgICAgICAgUEVSUk9SKCJGYWlsZWQgdG8gb2J0YWluIGhvc3QgZmVhdHVyZXNldCIpOwo+ ICsgICAgICAgICAgICAgICAgcmMgPSAtZXJybm87Cj4gKyAgICAgICAgICAgICAgICBnb3RvIG91 dDsKPiArICAgICAgICAgICAgfQo+ICsgICAgICAgIH0KPiArCj4gKyAgICAgICAgLyoKPiArICAg ICAgICAgKiBPbiBoYXJkd2FyZSB3aXRob3V0IENQVUlEIEZhdWx0aW5nLCBQViBndWVzdHMgc2Vl IHJlYWwgdG9wb2xvZ3kuCj4gKyAgICAgICAgICogQXMgYSBjb25zZXF1ZW5jZSwgdGhleSBhbHNv IG5lZWQgdG8gc2VlIHRoZSBob3N0IGh0dC9jbXAgZmllbGRzLgo+ICsgICAgICAgICAqLwo+ICsg ICAgICAgIHAtPmJhc2ljLmh0dCAgICAgICA9IHRlc3RfYml0KFg4Nl9GRUFUVVJFX0hUVCwgaG9z dF9mZWF0dXJlc2V0KTsKPiArICAgICAgICBwLT5leHRkLmNtcF9sZWdhY3kgPSB0ZXN0X2JpdChY ODZfRkVBVFVSRV9DTVBfTEVHQUNZLCBob3N0X2ZlYXR1cmVzZXQpOwo+ICsgICAgfQo+ICsgICAg ZWxzZQo+ICsgICAgewo+ICsgICAgICAgIC8qCj4gKyAgICAgICAgICogVG9wb2xvZ3kgZm9yIEhW TSBndWVzdHMgaXMgZW50aXJlbHkgY29udHJvbGxlZCBieSBYZW4uICBGb3Igbm93LCB3ZQo+ICsg ICAgICAgICAqIGhhcmRjb2RlIEFQSUNfSUQgPSB2Y3B1X2lkICogMiB0byBnaXZlIHRoZSBpbGx1 c2lvbiBvZiBubyBTTVQuCj4gKyAgICAgICAgICovCj4gKyAgICAgICAgcC0+YmFzaWMuaHR0ID0g dHJ1ZTsKPiArICAgICAgICBwLT5leHRkLmNtcF9sZWdhY3kgPSBmYWxzZTsKPiArCj4gKyAgICAg ICAgLyoKPiArICAgICAgICAgKiBFQlhbMjM6MTZdIGlzIE1heGltdW0gTG9naWNhbCBQcm9jZXNz b3JzIFBlciBQYWNrYWdlLgo+ICsgICAgICAgICAqIFVwZGF0ZSB0byByZWZsZWN0IHZMQVBJQ19J RCA9IHZDUFVfSUQgKiAyLCBidXQgbWFrZSBzdXJlIHRvIGF2b2lkCj4gKyAgICAgICAgICogb3Zl cmZsb3cuCj4gKyAgICAgICAgICovCj4gKyAgICAgICAgaWYgKCAhKHAtPmJhc2ljLmxwcHAgJiAw eDgwKSApCj4gKyAgICAgICAgICAgIHAtPmJhc2ljLmxwcHAgKj0gMjsKCkkgdGhpbmsgeW91IHdh bnQgdG8gc3RhcnQgdGhlIGNvbW1lbnQgd2l0aCAiTGVhZiAxIEVCWFsyMzoxNl0gLi4uIiwKYXMg cC0+YmFzaWMgY292ZXJzIGFsbCBiYXNpYyBsZWF2ZXMuCgpBZGRpdGlvbmFsbHksIHdoaWxlIHVz aW5nIG1hc2tpbmcgaW5zdGVhZCBvZiBhIHJlbGF0aW9uYWwgb3BlcmF0b3IKaXMgY29ycmVjdCBo ZXJlLCAuLi4KCj4gKyAgICAgICAgc3dpdGNoICggcC0+eDg2X3ZlbmRvciApCj4gKyAgICAgICAg ewo+ICsgICAgICAgIGNhc2UgWDg2X1ZFTkRPUl9JTlRFTDoKPiArICAgICAgICAgICAgZm9yICgg aSA9IDA7IChwLT5jYWNoZS5zdWJsZWFmW2ldLnR5cGUgJiYKPiArICAgICAgICAgICAgICAgICAg ICAgICAgICBpIDwgQVJSQVlfU0laRShwLT5jYWNoZS5yYXcpKTsgKytpICkKPiArICAgICAgICAg ICAgewo+ICsgICAgICAgICAgICAgICAgcC0+Y2FjaGUuc3VibGVhZltpXS5jb3Jlc19wZXJfcGFj a2FnZSA9Cj4gKyAgICAgICAgICAgICAgICAgICAgKHAtPmNhY2hlLnN1YmxlYWZbaV0uY29yZXNf cGVyX3BhY2thZ2UgPDwgMSkgfCAxOwo+ICsgICAgICAgICAgICAgICAgcC0+Y2FjaGUuc3VibGVh ZltpXS50aHJlYWRzX3Blcl9jYWNoZSA9IDA7Cj4gKyAgICAgICAgICAgIH0KPiArICAgICAgICAg ICAgYnJlYWs7Cj4gKwo+ICsgICAgICAgIGNhc2UgWDg2X1ZFTkRPUl9BTUQ6Cj4gKyAgICAgICAg Y2FzZSBYODZfVkVORE9SX0hZR09OOgo+ICsgICAgICAgICAgICAvKgo+ICsgICAgICAgICAgICAg KiBFQ1hbMTU6MTJdIGlzIEFwaWNJZENvcmVTaXplLgo+ICsgICAgICAgICAgICAgKiBFQ1hbNzow XSBpcyBOdW1iZXJPZkNvcmVzIChtaW51cyBvbmUpLgo+ICsgICAgICAgICAgICAgKiBVcGRhdGUg dG8gcmVmbGVjdCB2TEFQSUNfSUQgPSB2Q1BVX0lEICogMi4gIEJ1dCBhdm9pZAo+ICsgICAgICAg ICAgICAgKiAtIG92ZXJmbG93LAo+ICsgICAgICAgICAgICAgKiAtIGdvaW5nIG91dCBvZiBzeW5j IHdpdGggbGVhZiAxIEVCWFsyMzoxNl0sCj4gKyAgICAgICAgICAgICAqIC0gaW5jcmVtZW50aW5n IEFwaWNJZENvcmVTaXplIHdoZW4gaXQncyB6ZXJvICh3aGljaCBjaGFuZ2VzIHRoZQo+ICsgICAg ICAgICAgICAgKiAgIG1lYW5pbmcgb2YgYml0cyA3OjApLgo+ICsgICAgICAgICAgICAgKi8KPiAr ICAgICAgICAgICAgaWYgKCAhKHAtPmV4dGQubmMgJiAweDgwKSApCgouLi4gaXQgaXNuJ3QgaGVy ZSwgaS5lLiB0aGlzIGlzbid0IGEgY29ycmVjdCB0cmFuc2Zvcm1hdGlvbiBvZiB0aGUKcmVjZW50 IGNoYW5nZSBmb3IgUm9tZSk6IElmIHRoZSB2YWx1ZSBpcyAweDdmIGhlcmUsIHRoZSB2YWx1ZSBp bgpsZWFmIDEgd291bGQgYmUgMHg4MC4gQW4gYWRqdXN0bWVudCwgaG93ZXZlciwgbmVlZHMgdG8g YmUgZG9uZQplaXRoZXIgdG8gYm90aCBsZWF2ZXMsIG9yIHRvIG5vbmUgb2YgdGhlbSwgdG8ga2Vl cCB0aGUgdmFsdWVzIGluCnN1ZmZpY2llbnQgc3luYyAoYW5kIEkgdGhpbmsgeW91J2QgYnJlYWsg Um9tZSBhZ2FpbiBvdGhlcndpc2UsIGFzCnAtPmV4dGQubmMgX2lzXyAweDdmIHRoZXJlKS4gSGVu Y2UgdGhlICIocmVnc1syXSAmIDB4ZmZ1KSA8IDB4N2Z1IgpjaGVjayBpbiBteSByZWNlbnQgcGF0 Y2guCgpMaWtlIGFib3ZlIEkgdGhpbmsgeW91IHdhbnQgdG8gbmFtZSB0aGUgKGV4dGVuZGVkKSBs ZWFmIGluIHRoZQpjb21tZW50LCBhcyBwLT5leHRkIHNpbWlsYXJseSBjb3ZlcnMgYWxsIGV4dGVu ZGVkIGxlYXZlcy4KCkphbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1k ZXZlbA==