From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D55F9C6FA8B for ; Thu, 22 Sep 2022 07:55:33 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.409995.652995 (Exim 4.92) (envelope-from ) id 1obH37-0001SV-4P; Thu, 22 Sep 2022 07:55:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 409995.652995; Thu, 22 Sep 2022 07:55:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obH37-0001SO-1Y; Thu, 22 Sep 2022 07:55:09 +0000 Received: by outflank-mailman (input) for mailman id 409995; Thu, 22 Sep 2022 07:55:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1obH35-0001SH-HG for xen-devel@lists.xenproject.org; Thu, 22 Sep 2022 07:55:07 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df4cbadd-3a4b-11ed-9374-c1cf23e5d27e; Thu, 22 Sep 2022 09:55:06 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id lh5so19112666ejb.10 for ; Thu, 22 Sep 2022 00:55:06 -0700 (PDT) Received: from [127.0.0.1] (dynamic-077-191-214-084.77.191.pool.telefonica.de. [77.191.214.84]) by smtp.gmail.com with ESMTPSA id u17-20020a056402065100b0045081dc93dfsm3166610edx.78.2022.09.22.00.55.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Sep 2022 00:55:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df4cbadd-3a4b-11ed-9374-c1cf23e5d27e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date; bh=XAn7c1pwQ/FfM7vHKOqOcGKKPoVtNy6cXXuDPbbsEMg=; b=KdwbP3Bc87qLjlpjsnO2AH1hFtCVaiTGJp44vkAjCHEyi2BVqdUN8ix+ddbhHaPK1r EqWJ5pPbZsCjVFS9e+dTsVJ0Foj6V+KoT4fRyJlz7QqnJ/8hVqxrc1Ho7ZLeIspC87hS EwLwWL/B0irPWwT9KoGor+fge4WF8zkBMONJ36LmRsHQ1cCTfxd9d0oVkt47Fb8ho6Yq vGRDgumcb7zLXHHzBCfP5aDStxiv4J7vmNbl/fZPXSp3qCOfLbaEdK0wuuYY9KcWK55E P9+VDLqy0HdpS4ndwVtZP2lM2k+QoDCxBOx6WyXF/QkqHcfEpOC7COF2TxEu7OhFiih6 yxPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=XAn7c1pwQ/FfM7vHKOqOcGKKPoVtNy6cXXuDPbbsEMg=; b=eij2bUdXUlVqZuq1jKWYm7LPtLl54CA5JXZ3/9Km98uublB1ejZctnmYQAlqLsWO7x 6RjdT2311a6O4PWdLcnU6OcZ22azP/dqCV2ir6yfmJHiiLM+7M31rQUjUb9TTlvYHcP+ tyxf/RtKC1ncZF12+82Nt4XBWuQcDu9GSUN7oFZG+ox3yQKfVLymQjO2JpOwbw2AXTBe yR2LmQpUPLgfCE1oEqqVa2CBQyRvG26rm038FYChEjyVtHltxlcVkEfVzkmLrvJKMh9v 7YAB1mKKJG+9zFk1WtpwVekpMSE+TiR93mWseXXdCcuSjWvRkZq3FCC0Lg16RtN/A2qy cbDw== X-Gm-Message-State: ACrzQf2nnE3tkPvcoGQ7aLNs1iqoYZR+W31fKGQil8/0iQuL0pWdXdgM aEQ4JbGhjcGL1JCxEkBCs2w= X-Google-Smtp-Source: AMsMyM4vh+kpWsvDAV6UjWoPXkkUVHDYB2adjnMzVWEdRb430ELqUeGucGcmkbkYyJGj0Q/DyqUmmQ== X-Received: by 2002:a17:906:9b93:b0:780:3b58:93e1 with SMTP id dd19-20020a1709069b9300b007803b5893e1mr1620475ejc.698.1663833305755; Thu, 22 Sep 2022 00:55:05 -0700 (PDT) Date: Thu, 22 Sep 2022 07:55:01 +0000 From: B To: Markus Armbruster CC: Alistair Francis , Bin Meng , Palmer Dabbelt , "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" , Magnus Damm , Aleksandar Rikalo , Bandan Das , Matthew Rosato , Daniel Henrique Barboza , Sergio Lopez , Alexey Kardashevskiy , Xiaojuan Yang , Cameron Esfahani , Michael Rolnik , Song Gao , Jagannathan Raman , Greg Kurz , Kamil Rytarowski , Peter Xu , Joel Stanley , Alistair Francis , "Dr. David Alan Gilbert" , Paolo Bonzini , haxm-team@intel.com, Roman Bolshakov , Eric Auger , David Gibson , =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Christian Borntraeger , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Stefan Hajnoczi , Qemu-block , Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , "open list:New World" , Cornelia Huck , Helge Deller , Stefano Stabellini , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , "open list:RISC-V" , Stafford Horne , Paul Durrant , Havard Skinnemoen , Elena Ufimtseva , Alexander Graf , Thomas Huth , Alex Williamson , Wenchao Wang , Tony Krowiak , Marcel Apfelbaum , qemu-s390x , =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Mark Cave-Ayland , Eric Farman , Reinoud Zandijk , Alexander Bulekov , Yanan Wang , "Edgar E. Iglesias" , Gerd Hoffmann , Tyrone Ting , "open list:X86" , Yoshinori Sato , John Snow , Richard Henderson , Darren Kenny , "open list:Overall" , Qiuhao Li , John G Johnson , Sunil Muthuswamy , Max Filippov , qemu-arm , Marcelo Tosatti , Peter Maydell , Anthony Perard , Andrew Jeffery , Artyom Tarasenko , Halil Pasic , "Maciej S. Szmigiero" , Jason Wang , David Hildenbrand , Laurent Vivier , Alistair Francis , Jason Herne Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState In-Reply-To: <87a66tgwd5.fsf@pond.sub.org> References: <20220919231720.163121-1-shentey@gmail.com> <20220919231720.163121-2-shentey@gmail.com> <87edw6xoog.fsf@pond.sub.org> <0BBD7391-7B2D-44E7-9396-D1747784B9DA@gmail.com> <87a66tgwd5.fsf@pond.sub.org> Message-ID: <58A6CCCB-7426-41A2-9D3A-0683FBC51F47@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 21=2E September 2022 04:55:02 UTC schrieb Markus Armbruster : >Bernhard Beschow writes: > >> Am 20=2E September 2022 11:36:47 UTC schrieb Markus Armbruster : >>>Alistair Francis writes: >>> >>>> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow wrote: >>>>> >>>>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims i= t to >>>>> inherit from TYPE_MACHINE=2E This is an inconsistency which can caus= e >>>>> undefined behavior such as memory corruption=2E >>>>> >>>>> Change SiFiveEState to inherit from MachineState since it is registe= red >>>>> as a machine=2E >>>>> >>>>> Signed-off-by: Bernhard Beschow >>>> >>>> Reviewed-by: Alistair Francis >>> >>>To the SiFive maintainers: since this is a bug fix, let's merge it righ= t >>>away=2E >> >> I could repost this particular patch with the three new tags (incl=2E F= ixes) if desired=2E > >Can't hurt, and could help the maintainers=2E [X] Done=2E Best regards, Bernhard