From: Norbert Manthey <nmanthey@amazon.de>
To: Wei Liu <wei.liu2@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Norbert Manthey <nmanthey@amazon.com>, xen-devel@lists.xen.org
Subject: Re: [MINOR FIXES 2/2] lowmemd: fix comparison in cleanup
Date: Mon, 20 Feb 2017 20:19:09 +0100 [thread overview]
Message-ID: <58cc33e9-9007-7386-bf41-195e9910639f@amazon.de> (raw)
In-Reply-To: <20170220165811.srohd3k75igxwf3g@citrix.com>
Hi Wei,
as far as I can tell, patch 1 has already been added:
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=71af7d4220227529ea43b898683d4d2e68a90ffd
Best,
Norbert
On 02/20/2017 05:58 PM, Wei Liu wrote:
> On Fri, Feb 17, 2017 at 11:31:01AM +0000, Andrew Cooper wrote:
>> On 17/02/17 10:47, Norbert Manthey wrote:
>>> The variable virq_port of type uint32_t was compared to being greater than
>>> -1. This check always results in false for unsigned data types, resulting
>>> in never cleaning up the memory. Furthermore, the initialization with a
>>> negative variable for an unsigned type has been fixed.
>>>
>>> Signed-off-by: Norbert Manthey <nmanthey@amazon.com>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
> Acked + applied this patch.
>
> Tried to apply patch 1 as well but it didn't apply cleanly.
>
> Wei.
>
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-20 19:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 10:47 (no subject) Norbert Manthey
2017-02-17 10:47 ` [MINOR FIXES 1/2] mm: fix memory cleanup Norbert Manthey
2017-02-17 11:29 ` Andrew Cooper
2017-02-17 10:47 ` [MINOR FIXES 2/2] lowmemd: fix comparison in cleanup Norbert Manthey
2017-02-17 11:31 ` Andrew Cooper
2017-02-20 16:58 ` Wei Liu
2017-02-20 19:19 ` Norbert Manthey [this message]
2017-02-20 20:10 ` Wei Liu
2017-02-17 11:35 ` (no subject) Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cc33e9-9007-7386-bf41-195e9910639f@amazon.de \
--to=nmanthey@amazon.de \
--cc=andrew.cooper3@citrix.com \
--cc=nmanthey@amazon.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).