From: Michal Orzel <michal.orzel@arm.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v2] xen/arm: kernel: Propagate the error if we fail to decompress the kernel
Date: Mon, 12 Apr 2021 08:45:51 +0200 [thread overview]
Message-ID: <591603c5-ebcb-e9d6-74a0-bed921458a69@arm.com> (raw)
In-Reply-To: <20210406191554.12012-1-julien@xen.org>
On 06.04.2021 21:15, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> Currently, we are ignoring any error from perform_gunzip() and replacing
> the compressed kernel with the "uncompressed" kernel.
>
> If there is a gzip failure, then it means that the output buffer may
> contain garbagge. So it can result to various sort of behavior that may
> be difficult to root cause.
>
> In case of failure, free the output buffer and propagate the error.
> We also need to adjust the return check for kernel_compress() as
> perform_gunzip() may return a positive value.
>
> Take the opportunity to adjust the code style for the check.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
>
> ---
> Changes in v2:
> - Fix build
> ---
Reviewed-by: Michal Orzel <michal.orzel@arm.com>
next prev parent reply other threads:[~2021-04-12 6:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 19:15 [PATCH v2] xen/arm: kernel: Propagate the error if we fail to decompress the kernel Julien Grall
2021-04-12 6:45 ` Michal Orzel [this message]
2021-04-18 18:26 ` Julien Grall
2021-05-10 17:47 ` PING " Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591603c5-ebcb-e9d6-74a0-bed921458a69@arm.com \
--to=michal.orzel@arm.com \
--cc=bertrand.marquis@arm.com \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).