From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] RFC x86/emul: Drop segment_attributes_t
Date: Wed, 07 Jun 2017 10:02:30 -0600 [thread overview]
Message-ID: <59383FB602000078001608F5@prv-mh.provo.novell.com> (raw)
In-Reply-To: <a18b88af-bf96-fd6c-37fa-4ac3c26aaacd@citrix.com>
>>> On 07.06.17 at 17:44, <andrew.cooper3@citrix.com> wrote:
> On 07/06/17 14:40, Jan Beulich wrote:
>>>>> On 07.06.17 at 15:04, <andrew.cooper3@citrix.com> wrote:
>>> Furthermore, in a following patch, I intend to make a similar adjustment as
>>> http://xenbits.xen.org/gitweb/?p=xtf.git;a=commitdiff;h=f099211f2ebdadf61ae6
>>> 416559220d69b788cd2b
>>> to expose the internal code/data field names. This will simplify a lot of
>>> code which currently uses opencoded numbers against the type field.
>> This is nice too, with two caveats: The "a" bit is not code
>> segment specific (but placed so)
>
> Least bad option I'm afraid. It can't live in the common struct because
> it is part of the type nibble, and it can't live in both the code and
> data anonymous unions because it has the same name.
It could be put in a 3rd struct, but I guess that's more extra
overhead than actual gain.
>> and the "x" bit is an invention
>> of yours afaict, which I'd prefer to be e.g. "code".
>
> It is the eXecutable bit. I got the terminology from one of the two
> manuals, but don't recall exactly where.
Oh, okay. I don't recall running across this.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-06-07 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 13:04 [PATCH] RFC x86/emul: Drop segment_attributes_t Andrew Cooper
2017-06-07 13:40 ` Jan Beulich
2017-06-07 15:44 ` Andrew Cooper
2017-06-07 16:02 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59383FB602000078001608F5@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).