xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Tim Deegan <tim@xen.org>, IanJackson <Ian.Jackson@eu.citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] public: there's no MMUEXT_SET_FOREIGNDOM
Date: Fri, 09 Jun 2017 06:50:04 -0600	[thread overview]
Message-ID: <593AB59C0200007800161578@prv-mh.provo.novell.com> (raw)
In-Reply-To: <452c6707-e0b2-1a9a-bbe6-1f4d482c4d12@citrix.com>

>>> On 09.06.17 at 14:29, <andrew.cooper3@citrix.com> wrote:
> On 08/06/17 16:19, Jan Beulich wrote:
>> Correct respective comments.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
>> ---
>> MMUEXT_{CLEAR,COPY}_PAGE in fact also allow to be invoked on DOMID_IO
>> owned pages at present. I've intentionally not added this to the text,
>> as I'm not sure we really mean to allow this. If we do, I think the
>> operation should also be allowed for MMIO pages not happening to have
>> an associated struct page_info.
> 
> Nothing actually uses the clear/copy subops, as far as I can tell,

The 32-bit XenoLinux (at least our forward port) has been using
them for certain highmem accesses.

> although they could actually be used for a minor performance
> optimisation for HVM domain builder domains, to avoid HAP mutations. 
> I'd agree with restricting them to RAM only.

Okay.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-06-09 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 15:19 [PATCH] public: there's no MMUEXT_SET_FOREIGNDOM Jan Beulich
2017-06-09 12:29 ` Andrew Cooper
2017-06-09 12:50   ` Jan Beulich [this message]
2017-06-09 13:20 ` Julien Grall
2017-06-09 13:24   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=593AB59C0200007800161578@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).