From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86emul: minor cleanup
Date: Mon, 12 Jun 2017 09:21:55 -0600 [thread overview]
Message-ID: <593ECDB3020000780016213E@prv-mh.provo.novell.com> (raw)
In-Reply-To: <efe2db68-f240-471f-983e-281c6a8da6f4@citrix.com>
>>> On 12.06.17 at 17:03, <andrew.cooper3@citrix.com> wrote:
> On 12/06/17 15:06, Jan Beulich wrote:
>>>>> On 12.06.17 at 14:41, <andrew.cooper3@citrix.com> wrote:
>>> On 12/06/17 07:23, Jan Beulich wrote:
>>>> As a side note, I'm removing these here since the further
>>>> SIMD emulation patches I have ready, but would prefer to
>>>> post only once 4.9 is out, do not add respective code in the
>>>> first place. Without knowing this in advance I'm not even
>>>> sure this would be reliably spottable during review.
>>> These what? Again sorry, I don't understand what you mean.
>> I have patches to add full AVX, F16C, FMA4, FMA, AVX2, XOP,
>> and 3DNow! support to the emulator. Various of the instructions
>> added can't raise #XM, and the patches don't set insn_bytes if
>> it's not needed for aforementioned generic code inserting RET.
>> I.e. what the patch here removes is what those patches won't
>> add in the first place, yielding an overall consistent result.
>
> Does this mean you have altered some of the instructions to be straight
> inline? I can't see how you could get away without a RET otherwise.
No, there are already now two cases: One (the most common) is
for SIMD insns to be taken care of by the respective code block
right after the big switch(). That code needs to know insn_bytes
to put the RET at the right spot. The other case is various less
generic insns being handled entirely inside their case blocks. The
respective code needs to place the RET itself, or else it couldn't
invoke the stub. But it doesn't need to set insn_bytes for that
reason. It is effectively one such case where the patch removes
the setting of the field (as well as the check_xmm_exn()), plus
one other case where the field simply is being set later, at a
point more consistent with how it's being done elsewhere (and
where there already is no matching check_xmm_exn()).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-06-12 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 15:49 [PATCH] x86emul: minor cleanup Jan Beulich
2017-06-09 17:50 ` Andrew Cooper
2017-06-12 6:23 ` Jan Beulich
2017-06-12 12:41 ` Andrew Cooper
2017-06-12 14:06 ` Jan Beulich
2017-06-12 15:03 ` Andrew Cooper
2017-06-12 15:21 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593ECDB3020000780016213E@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).