From: Jan Beulich <jbeulich@suse.com>
To: Paul Durrant <paul@xen.org>
Cc: "Juergen Gross" <jgross@suse.com>, "Wei Liu" <wl@xen.org>,
"George Dunlap" <george.dunlap@eu.citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration
Date: Tue, 8 Oct 2019 10:25:29 +0200 [thread overview]
Message-ID: <597ea92f-fa61-b47b-448a-1e6f4aebe994@suse.com> (raw)
In-Reply-To: <20191001151159.861-1-paul.durrant@citrix.com>
On 01.10.2019 17:11, Paul Durrant wrote:
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -209,15 +209,15 @@ static int paging_free_log_dirty_bitmap(struct domain *d, int rc)
> return rc;
> }
>
> -int paging_log_dirty_enable(struct domain *d, bool_t log_global)
> +int paging_log_dirty_enable(struct domain *d, bool log_global)
> {
> int ret;
>
> - if ( is_iommu_enabled(d) && log_global )
> + if ( has_arch_pdevs(d) && iommu_use_hap_pt(d) && log_global )
To unblock a push to master, the is_iommu_enabled() -> has_arch_pdevs()
transformation here is needed afaict. Since the other half of the
change here (and a corresponding change to assign_device()) continues
to be controversial, could we agree on splitting this patch into two?
(I'd be fine doing the legwork.)
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-08 8:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 15:11 [Xen-devel] [PATCH-for-4.13 v2] x86/mm: don't needlessly veto migration Paul Durrant
2019-10-02 8:40 ` Jan Beulich
2019-10-02 8:59 ` Paul Durrant
2019-10-02 9:26 ` Jan Beulich
2019-10-02 9:30 ` Paul Durrant
2019-10-02 9:10 ` Andrew Cooper
2019-10-02 9:32 ` Paul Durrant
2019-10-02 9:40 ` Jan Beulich
2019-10-02 9:55 ` Paul Durrant
2019-10-04 16:48 ` George Dunlap
2019-10-08 8:25 ` Jan Beulich [this message]
2019-10-08 9:54 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=597ea92f-fa61-b47b-448a-1e6f4aebe994@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jgross@suse.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).