From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: Julien Grall <jgrall@amazon.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7
Date: Thu, 8 Apr 2021 08:17:36 +0200 [thread overview]
Message-ID: <59afb632-f2c9-bf3d-ef97-bc9f5a95d0a6@suse.com> (raw)
In-Reply-To: <20210407182726.26603-1-julien@xen.org>
On 07.04.2021 20:27, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The compilation will fail when building Xen with clang and
> CONFIG_DEBUG=y:
>
> make[4]: Leaving directory '/oss/xen/xen/common/libelf'
> INIT_O gunzip.init.o
> Error: size of gunzip.o:.text is 0x00000019
>
> This is because the function init_allocator() will not be inlined
> and is not part of the init section.
>
> Fix it by marking init_allocator() with INIT.
>
> Fixes: 33bc2a8495f7 ("xen/gunzip: Allow perform_gunzip() to be called multiple times")
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2021-04-08 6:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 18:27 [PATCH] xen/gunzip: Fix build with clang after 33bc2a8495f7 Julien Grall
2021-04-08 6:17 ` Jan Beulich [this message]
2021-04-09 8:43 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59afb632-f2c9-bf3d-ef97-bc9f5a95d0a6@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).