From: "Jan Beulich" <JBeulich@suse.com>
To: george.dunlap@citrix.com
Cc: Wei Liu <wei.liu2@citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH V11 4/5] p2m: Always use hostp2m when clipping rangesets
Date: Thu, 20 Dec 2018 08:01:30 -0700 [thread overview]
Message-ID: <5C1BAECA02000078002081B2@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <49204ce7-bb5f-2aad-a2b8-a2219db89260@citrix.com>
>>> On 20.12.18 at 15:38, <george.dunlap@citrix.com> wrote:
> At the moment I'm only working 4-ish more days between now and the code
> freeze, and we're arguing over whether the comment should say, "We
> should probably do X instead" or "We should probably do Y instead."
>
> Can we just for now take the text as I proposed it? You can argue about
> the right thing to do when we do the alleged clean-up.
Oh, and btw - while I see where you're coming from, I don't like
taking an approaching code freeze as an excuse to short circuit
anything, neither reviews nor discussions. In the end it's a
comment only here, but the overall situation is (apparently)
unclear enough that a new misleading comment is not going to
help at all, the more that we all know how intended cleanups
often work out once the main roadblock is out of the way.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-12-20 15:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 9:18 [PATCH V11 0/5] Fix VGA logdirty related display freezes with altp2m Razvan Cojocaru
2018-12-05 9:18 ` [PATCH V11 1/5] x86/p2m: allocate logdirty_ranges for altp2ms Razvan Cojocaru
2018-12-05 9:18 ` [PATCH V11 2/5] x86/p2m: refactor p2m_reset_altp2m() Razvan Cojocaru
2018-12-05 9:18 ` [PATCH V11 3/5] x86/altp2m: fix display frozen when switching to a new view early Razvan Cojocaru
2018-12-20 15:31 ` George Dunlap
2018-12-05 9:18 ` [PATCH V11 4/5] p2m: Always use hostp2m when clipping rangesets Razvan Cojocaru
2018-12-05 16:30 ` Jan Beulich
2018-12-13 10:22 ` Razvan Cojocaru
2018-12-13 10:43 ` Jan Beulich
2018-12-19 17:26 ` George Dunlap
2018-12-20 8:20 ` Jan Beulich
2018-12-20 12:59 ` George Dunlap
2018-12-20 13:52 ` Jan Beulich
2018-12-20 14:38 ` George Dunlap
2018-12-20 14:49 ` Jan Beulich
2018-12-20 15:14 ` Razvan Cojocaru
2018-12-20 15:22 ` George Dunlap
2018-12-20 15:01 ` Jan Beulich [this message]
2018-12-20 16:09 ` George Dunlap
2018-12-20 16:25 ` Razvan Cojocaru
2018-12-20 16:31 ` George Dunlap
2018-12-20 16:46 ` Razvan Cojocaru
2018-12-05 9:18 ` [PATCH V11 5/5] p2m: change_type_range: Only invalidate mapped gfns Razvan Cojocaru
2018-12-20 16:17 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C1BAECA02000078002081B2@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=rcojocaru@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).