From: "Jan Beulich" <JBeulich@suse.com>
To: "Baodong Chen" <chenbaodong@mxnavi.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, WeiLiu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen/coverage: wrap coverage related things under 'CONFIG_COVERAGE'
Date: Tue, 11 Jun 2019 08:03:15 -0600 [thread overview]
Message-ID: <5CFFB4A30200007800237133@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <1560232949-10673-1-git-send-email-chenbaodong@mxnavi.com>
>>> On 11.06.19 at 08:02, <chenbaodong@mxnavi.com> wrote:
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -240,12 +240,14 @@ SECTIONS
> *(.altinstructions)
> __alt_instructions_end = .;
>
> +#if defined(CONFIG_COVERAGE)
> . = ALIGN(8);
> __ctors_start = .;
> *(.ctors)
> *(.init_array)
> *(SORT(.init_array.*))
> __ctors_end = .;
> +#endif
How is this (only) coverage related? And how is making this conditional
going to help in any way?
And if we were to take this, then please use the shorter #ifdef.
> --- a/xen/common/lib.c
> +++ b/xen/common/lib.c
> @@ -491,15 +491,20 @@ unsigned long long parse_size_and_unit(const char *s, const char **ps)
> return ret;
> }
>
> +#if defined(CONFIG_COVERAGE)
> typedef void (*ctor_func_t)(void);
> extern const ctor_func_t __ctors_start[], __ctors_end[];
> +#endif
Again - how does this help?
> +/* see 'docs/hypervisor-guide/code-coverage.rst' */
> void __init init_constructors(void)
There's no mention of this function in the referenced docs file.
> {
> +#if defined(CONFIG_COVERAGE)
> const ctor_func_t *f;
> for ( f = __ctors_start; f < __ctors_end; ++f )
> (*f)();
>
> +#endif
> /* Putting this here seems as good (or bad) as any other place. */
Again, besides lacking suitable reasoning you also should look
more closely, in this case where exactly it makes sense to place
the #endif.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-11 14:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 6:02 [Xen-devel] [PATCH] xen/coverage: wrap coverage related things under 'CONFIG_COVERAGE' Baodong Chen
2019-06-11 14:03 ` Jan Beulich [this message]
2019-06-12 0:23 ` chenbaodong
2019-06-12 6:34 ` Jan Beulich
2019-06-12 7:36 ` chenbaodong
2019-06-12 7:58 ` Jan Beulich
2019-06-12 8:49 ` chenbaodong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CFFB4A30200007800237133@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=chenbaodong@mxnavi.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).