On 13.04.21 19:20, Olaf Hering wrote: > Move all save/restore related code from libxenguest.so into a separate > library libxensaverestore.so. The only consumer is libxl-save-helper. > There is no need to have the moved code mapped all the time in binaries > where libxenguest.so is used. > > According to size(1) the change is: > text data bss dec hex filename > 187183 4304 48 191535 2ec2f guest/libxenguest.so.4.15.0 > > 124106 3376 48 127530 1f22a guest/libxenguest.so.4.15.0 > 67841 1872 8 69721 11059 saverestore/libxensaverestore.so.4.15.0 > > Signed-off-by: Olaf Hering > --- > v3: > - repost in time for 4.16 > v2: > - copy also license header > - move xg_nomigrate.c > - add size(1) output to commit msg > - remove change from libxl_create.c > > .gitignore | 2 + > tools/include/xenguest.h | 186 ---------------- > tools/include/xensaverestore.h | 208 ++++++++++++++++++ > tools/libs/Makefile | 1 + > tools/libs/guest/Makefile | 11 - > tools/libs/guest/xg_offline_page.c | 1 - > tools/libs/light/Makefile | 4 +- > tools/libs/light/libxl_internal.h | 1 + > tools/libs/light/libxl_save_helper.c | 1 + > tools/libs/light/libxl_save_msgs_gen.pl | 2 +- > tools/libs/saverestore/Makefile | 38 ++++ > .../{guest => saverestore}/xg_nomigrate.c | 0 > .../{guest => saverestore}/xg_save_restore.h | 2 - > .../{guest => saverestore}/xg_sr_common.c | 0 > .../{guest => saverestore}/xg_sr_common.h | 12 + > .../{guest => saverestore}/xg_sr_common_x86.c | 0 > .../{guest => saverestore}/xg_sr_common_x86.h | 0 > .../xg_sr_common_x86_pv.c | 0 > .../xg_sr_common_x86_pv.h | 0 > .../{guest => saverestore}/xg_sr_restore.c | 0 > .../xg_sr_restore_x86_hvm.c | 0 > .../xg_sr_restore_x86_pv.c | 0 > .../libs/{guest => saverestore}/xg_sr_save.c | 0 > .../xg_sr_save_x86_hvm.c | 0 > .../xg_sr_save_x86_pv.c | 0 > .../xg_sr_stream_format.h | 0 > tools/libs/uselibs.mk | 4 +- > 27 files changed, 269 insertions(+), 204 deletions(-) > create mode 100644 tools/include/xensaverestore.h > create mode 100644 tools/libs/saverestore/Makefile > rename tools/libs/{guest => saverestore}/xg_nomigrate.c (100%) > rename tools/libs/{guest => saverestore}/xg_save_restore.h (98%) > rename tools/libs/{guest => saverestore}/xg_sr_common.c (100%) > rename tools/libs/{guest => saverestore}/xg_sr_common.h (98%) > rename tools/libs/{guest => saverestore}/xg_sr_common_x86.c (100%) > rename tools/libs/{guest => saverestore}/xg_sr_common_x86.h (100%) > rename tools/libs/{guest => saverestore}/xg_sr_common_x86_pv.c (100%) > rename tools/libs/{guest => saverestore}/xg_sr_common_x86_pv.h (100%) > rename tools/libs/{guest => saverestore}/xg_sr_restore.c (100%) > rename tools/libs/{guest => saverestore}/xg_sr_restore_x86_hvm.c (100%) > rename tools/libs/{guest => saverestore}/xg_sr_restore_x86_pv.c (100%) > rename tools/libs/{guest => saverestore}/xg_sr_save.c (100%) > rename tools/libs/{guest => saverestore}/xg_sr_save_x86_hvm.c (100%) > rename tools/libs/{guest => saverestore}/xg_sr_save_x86_pv.c (100%) > rename tools/libs/{guest => saverestore}/xg_sr_stream_format.h (100%) What about dropping the "xg_" prefix from the filenames? Juergen