xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Artem Mygaiev <joculator@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Artem Mygaiev <artem_mygaiev@epam.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	Artem Mygaiev <joculator@gmail.com>
Subject: [Xen-devel] [PATCH 1/3] Consistent use for lock variable
Date: Wed,  9 Oct 2019 17:20:15 +0300	[thread overview]
Message-ID: <5eec779f850fec88caeb67a090a25092792689ba.1570628924.git.artem_mygaiev@epam.com> (raw)
In-Reply-To: <cover.1570628924.git.artem_mygaiev@epam.com>

... for both lock and unlock

Coverity-ID: 1381840
Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
---
 xen/xsm/flask/avc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/xsm/flask/avc.c b/xen/xsm/flask/avc.c
index 87ea38b7a0..3a9507f62a 100644
--- a/xen/xsm/flask/avc.c
+++ b/xen/xsm/flask/avc.c
@@ -320,7 +320,7 @@ static inline int avc_reclaim_node(void)
         head = &avc_cache.slots[hvalue];
         lock = &avc_cache.slots_lock[hvalue];
 
-        spin_lock_irqsave(&avc_cache.slots_lock[hvalue], flags);
+        spin_lock_irqsave(lock, flags);
         rcu_read_lock(&avc_rcu_lock);
         hlist_for_each_entry(node, next, head, list)
         {
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-10-09 14:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09 14:20 [Xen-devel] [PATCH 0/3] Minor Coverity fixes Artem Mygaiev
2019-10-09 14:20 ` Artem Mygaiev [this message]
2020-01-18 13:09   ` [Xen-devel] [PATCH 1/3] Consistent use for lock variable Julien Grall
2019-10-09 14:20 ` [Xen-devel] [PATCH 2/3] Remove useless ASSERT condition Artem Mygaiev
2019-10-09 14:56   ` Julien Grall
2020-01-18 12:58     ` Julien Grall
2019-10-09 14:20 ` [Xen-devel] [PATCH 3/3] Free allocated resource on error Artem Mygaiev
2019-10-09 15:24   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5eec779f850fec88caeb67a090a25092792689ba.1570628924.git.artem_mygaiev@epam.com \
    --to=joculator@gmail.com \
    --cc=artem_mygaiev@epam.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).