From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19BF7C433FE for ; Wed, 9 Dec 2020 09:41:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1DE5233FA for ; Wed, 9 Dec 2020 09:41:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1DE5233FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.48056.85006 (Exim 4.92) (envelope-from ) id 1kmvyI-0002P8-PV; Wed, 09 Dec 2020 09:41:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 48056.85006; Wed, 09 Dec 2020 09:41:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmvyI-0002P1-MV; Wed, 09 Dec 2020 09:41:18 +0000 Received: by outflank-mailman (input) for mailman id 48056; Wed, 09 Dec 2020 09:41:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmvyH-0002Ov-Ax for xen-devel@lists.xenproject.org; Wed, 09 Dec 2020 09:41:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmvyG-0003ll-2k; Wed, 09 Dec 2020 09:41:16 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kmvyF-0003ae-RU; Wed, 09 Dec 2020 09:41:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=R4sJhaKCXsab7iT7m8N1tJ5o9kZxMmHfCEkyfLNMiSA=; b=yQgbxDNMHmrd4/QQFkEXNfiMJq +34D272EPBBURZNCpPJjJH3EnkOvHQi9fIhquyco9hWq2kDUSYjXYYQuewbzUYWA0PIrJ25L8EUB0 p5nnLu01DIkdELUNtv52bC+l5nsrVlsvk2AlwvC8OBI576se4XhNSJu1hUlR6VKMuqIM=; Subject: Re: [PATCH v2 7/8] lib: move bsearch code To: Jan Beulich Cc: George Dunlap , Ian Jackson , Wei Liu , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Andrew Cooper References: <87a20884-5a76-a664-dcc9-bd4becee40b3@suse.com> <44ffc041-cacd-468e-a835-f5b2048bb201@xen.org> <2cf3a90d-f463-41f8-f861-6ef00279b204@suse.com> <2419eccf-c696-6aa1-ada4-0f7bd6bc5657@xen.org> <77534dc3-bdd6-f884-99e3-90dc9b02a81f@citrix.com> <59a4e1c1-ea39-1846-92ae-92560db4b1fb@xen.org> From: Julien Grall Message-ID: <5fc44865-2115-947c-bd22-b51d7f17d39c@xen.org> Date: Wed, 9 Dec 2020 09:41:13 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Jan, On 07/12/2020 10:23, Jan Beulich wrote: > On 24.11.2020 17:57, Julien Grall wrote: >> On 24/11/2020 00:40, Andrew Cooper wrote: >>> On a totally separate point,  I wonder if we'd be better off compiling >>> with -fgnu89-inline because I can't see any case we're we'd want the C99 >>> inline semantics anywhere in Xen. >> >> This was one of my point above. It feels that if we want to use the >> behavior in Xen, then it should be everywhere rather than just this helper. > > I'll be committing the series up to patch 6 in a minute. It remains > unclear to me whether your responses on this sub-thread are meant > to be an objection, or just a comment. Andrew gave his R-b despite > this separate consideration, and I now also have an ack from Wei > for the entire series. Please clarify. It still feels strange to apply to one function and not the others... But I don't have a strong objection against the idea of using C99 inlines in Xen. IOW, I will neither Ack nor NAck this patch. > > Or actually I only thought I could commit a fair initial part of > the series - I'm still lacking Arm-side acks for patches 2 and 3 > here. If you remember, I have asked if Anthony could review the build system because he worked on it recently. Unfortunately, I haven't seen any answer so far... I have pinged him on IRC. Cheers, -- Julien Grall