From: Juergen Gross <jgross@suse.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Jan Beulich" <jbeulich@suse.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
Dario Faggioli <dfaggioli@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging runqueues
Date: Mon, 3 Oct 2022 09:47:23 +0200 [thread overview]
Message-ID: <601e21a6-f42b-f972-1eb0-52d5f97804e5@suse.com> (raw)
In-Reply-To: <Yym+1k7YlkMpvvaU@mail-itl>
[-- Attachment #1.1.1: Type: text/plain, Size: 1284 bytes --]
On 20.09.22 15:23, Marek Marczykowski-Górecki wrote:
> On Tue, Sep 20, 2022 at 11:06:57AM +0200, Jan Beulich wrote:
>> On 19.09.2022 17:09, Marek Marczykowski-Górecki wrote:
>>> --- a/xen/common/sched/credit2.c
>>> +++ b/xen/common/sched/credit2.c
>>> @@ -996,9 +996,13 @@ cpu_add_to_runqueue(const struct scheduler *ops, unsigned int cpu)
>>> *
>>> * Otherwise, let's try to make sure that siblings stay in the
>>> * same runqueue, pretty much under any cinrcumnstances.
>>> + *
>>> + * Furthermore, try to respect credit2_runqueue=all, as long as
>>> + * max_cpus_runq isn't violated.
>>
>> This last part is questionable, partly because the command line doc is
>> ambiguous as to which of the two options is intended to "win". I guess
>> one needs to know the original intentions to resolve this.
>
> Right, I've chosen this approach, because you can still emulate the
> other by setting sufficiently large max_cpus_runq. I can add doc
> clarification in v2.
>
I think this is the better approach, as it allows more flexibility.
Updating the doc would be mandatory, though. With that added you can
have my:
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2022-10-03 7:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 15:09 [PATCH] xen: credit2: respect credit2_runqueue=all when arranging runqueues Marek Marczykowski-Górecki
2022-09-20 9:06 ` Jan Beulich
2022-09-20 13:23 ` Marek Marczykowski-Górecki
2022-10-03 7:47 ` Juergen Gross [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-19 15:04 Marek Marczykowski-Górecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=601e21a6-f42b-f972-1eb0-52d5f97804e5@suse.com \
--to=jgross@suse.com \
--cc=dfaggioli@suse.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).