From: Julien Grall <julien.grall@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] xen/domctl: Add DOMINFO_hap to xen_domctl_getdomaininfo
Date: Wed, 20 Jul 2016 12:38:31 +0100 [thread overview]
Message-ID: <60705c12-0522-169e-2841-385cb3f62431@arm.com> (raw)
In-Reply-To: <1468601865-10802-1-git-send-email-andrew.cooper3@citrix.com>
Hi Andrew,
On 15/07/16 17:57, Andrew Cooper wrote:
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index f61f98a..afa16d8 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -14,6 +14,12 @@
> #include <xsm/xsm.h>
> #include <public/domctl.h>
>
> +void arch_get_domain_info(const struct domain *d,
> + struct xen_domctl_getdomaininfo *info)
> +{
> + info->flags |= XEN_DOMINF_hap;
> +}
> +
The ARM change looks good to me. I have just one request, would be it
possible to add a comment in the code explaining why hap is
unconditionally set? (I.e domains are always using hap on ARM).
With that:
Reviewed-by: Julien Grall <julien.grall@arm.com>
> long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
> XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
> {
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-20 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 16:57 [PATCH] xen/domctl: Add DOMINFO_hap to xen_domctl_getdomaininfo Andrew Cooper
2016-07-18 15:26 ` Wei Liu
2016-07-20 11:38 ` Julien Grall [this message]
2016-07-27 11:01 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60705c12-0522-169e-2841-385cb3f62431@arm.com \
--to=julien.grall@arm.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).